Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release via GHA #229

Merged
merged 11 commits into from
Nov 30, 2023
Merged

Release via GHA #229

merged 11 commits into from
Nov 30, 2023

Commits on Nov 13, 2023

  1. Add workflow for release via gh actions 

    taken from: https://github.com/guardian/content-api-firehose-client/blob/main/.github/workflows/release-snapshot.yml
    @jonathonherbert
    jonathonherbert committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    7038ff0 View commit details
    Browse the repository at this point in the history

  2. First pass at GHA workflow

    @jonathonherbert
    jonathonherbert committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    1da6d8b View commit details
    Browse the repository at this point in the history

  3. Remove npm cache, which relies on a non-existent lockfile

    @jonathonherbert
    jonathonherbert committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    250187c View commit details
    Browse the repository at this point in the history

  4. Add NPM token to secrets exposed in env vars

    @jonathonherbert
    jonathonherbert committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    1a203e7 View commit details
    Browse the repository at this point in the history

  5. Add NPM token env var; remove local version

    @jonathonherbert
    jonathonherbert committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    eb411b4 View commit details
    Browse the repository at this point in the history

  6. Update release steps to prepare for remote release

    @jonathonherbert
    jonathonherbert committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    6d2697c View commit details
    Browse the repository at this point in the history

  7. More stack 

    To prevent stack overflow errors on compile
    @jonathonherbert
    jonathonherbert committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    de02a80 View commit details
    Browse the repository at this point in the history

  8. Correct environment variable, and add registry-url 

    Both of which are required for setup-node to write an npmrc file to disk, and for npm to read the appropriate env var from the npmrc file – see https://github.com/actions/setup-node/blob/ee36e8b5c0fdd6014a0398aed18ce9876360bd63/src/authutil.ts#L48 and https://npm.github.io/installation-setup-docs/customizing/the-npmrc-file.html
    @jonathonherbert
    jonathonherbert committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    c9b6ede View commit details
    Browse the repository at this point in the history

  9. Reinstate version and prerelease conditional

    @jonathonherbert
    jonathonherbert committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    c6b74ad View commit details
    Browse the repository at this point in the history

  10. Test release

    @jonathonherbert
    jonathonherbert committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    a996b51 View commit details
    Browse the repository at this point in the history

  11. Add release instructions to README

    @jonathonherbert
    jonathonherbert committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    8c01466 View commit details
    Browse the repository at this point in the history