Add advertisement feature design type #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @blongden73 |
nicl
added a commit
to guardian/frontend
that referenced
this pull request
Jan 20, 2020
...because we now support AdvertisementFeature as a design type in the latest CAPI client version. See: guardian/content-api-scala-client#294.
nicl
added a commit
to guardian/frontend
that referenced
this pull request
Jan 20, 2020
...because we now support AdvertisementFeature as a design type in the latest CAPI client version. See: guardian/content-api-scala-client#294.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets design type to the new value of
AdvertisementFeaturewhen advertising-feature tone tag is present.We already perform this logic in Frontend, but feels better to do it at source. See: https://github.com/guardian/frontend/blob/master/article/app/model/dotcomponents/DotcomponentsDataModel.scala#L400
@JustinPinner and @regiskuckaertz not sure exactly how to deploy a new version here and what is involved beyond the changelog addition. Can you help?!