Tell AsyncHttpClient not to re-use connections for more than 60s #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default it will keep a connection in the pool for ever: https://github.com/AsyncHttpClient/async-http-client/blob/async-http-client-1.8.10/src/main/java/com/ning/http/client/AsyncHttpClientConfigDefaults.java#L56 The configured value is used here: https://github.com/AsyncHttpClient/async-http-client/blob/async-http-client-1.8.10/src/main/java/com/ning/http/client/providers/netty/NettyConnectionsPool.java#L178
|
👍 great catch! |
cb372
added a commit
that referenced
this pull request
Mar 3, 2015
Tell AsyncHttpClient not to re-use connections for more than 60s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After another look through the AsyncHttpClient source code today, it turns out that it is possible to configure its connection pool to solve our DNS caching woes. I've checked with manual testing that this works as expected.
This is a better fix than #64 because it means we can keep Netty, so there are no performance worries.
By default AsyncHttpClient will keep a connection in the pool for ever:
https://github.com/AsyncHttpClient/async-http-client/blob/async-http-client-1.8.10/src/main/java/com/ning/http/client/AsyncHttpClientConfigDefaults.java#L56
The configured value is used here:
https://github.com/AsyncHttpClient/async-http-client/blob/async-http-client-1.8.10/src/main/java/com/ning/http/client/providers/netty/NettyConnectionsPool.java#L178
@mchv @LATaylor-guardian