-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[for discussion] proposal for a Video atom #103
Conversation
I think that's sensible to separate audio and video. FWIW, the library we are working on is designed to handle as many rendering surfaces as necessary. In other words, the same atom can be rendered differently depending on the context (facebook et al) and there is no need for any rendering code anywhere anymore (composer, atom-workshop, frontend, or even the |
YESSSS!!!! 👍 I mentioned Facebook etc as the original intention of the media atom was to upload content to those platforms. This has since evolved into a similar pattern we employed before, that is, Audience recut the video and upload to FB natively. For example, this video on theguardian.com is here on facebook.com. I propose we simplify the |
I see, that's smart! Then how do you know which asset is for which platform? Is it that I wonder if turning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think generally this seems like a sane approach. How will things be migrated?
FEATURE = 2, | ||
NEWS = 3, | ||
HOSTED = 4, // commercial content supplied by advertiser | ||
PAIDFOR = 5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you have a hosted documentary? Are these different things? Oh - it's not used anywhere anyway...
@akash1810 another old PR - time to close or salvage? |
Since we're adding an |
Would love to chat what a CAPI migration would look like for this. |
@akash1810 @franziskas so you're aware, we'll be going ahead with this after we've done all the work to remove the mapping type in elasticsearch 😇 |
👋🏽 @guardian/content-platforms I just remembered this PR. Do you know how far Regis got with it? And/or shall we close it? |
i don't know why but for some reason im on email thread for this 😢 ❤️ am i still on an old team by accident? |
I got this as well, hello everyone! 😁 |
Hey @annebyrne @marialivia16 👋🏽. Totally surprised by that! I suspect you are/were repo watchers? In any case, hope you're both keeping well? |
nah only watching for things i participated in but can't see myself in thread. just wanted to flag anyway in case i was on a github team somewhere by accident |
Closing, as unlikely to be worked on. |
The media atom has evolved over time and as a result its not entirely obvious what's what, for example, there's a
posterUrl
field and aposterImage
field, there's aMetadata
struct which primarily holds youtube metadata, however it also hasPlutoData
.Furthermore, the media atom has been designed for audio and video across multiple platforms. Its unlikely we'll get the opportunity to realising these initial plans. Additionally, I don't think we'll ever publish an atom to the facebook, dailymotion or mainstream platforms, primarily because the content on these platforms is often a different version of the content used on site. As a result, the
Platform
enum is a lot simpler.This is a proposal for a video atom definition. There's no intention of using it in production, its more for discussion... unless of course its beneficial to migrate atoms...