Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add emailsignup atom #133

Merged
merged 4 commits into from
Jan 21, 2020
Merged

Add emailsignup atom #133

merged 4 commits into from
Jan 21, 2020

Conversation

amyhughes
Copy link
Contributor

@amyhughes amyhughes commented Sep 2, 2019

This should support an atom type for Editorial email sign up boxes, currently included as html snippets like this:

<figure class="element element-embed" data-alt="Business email signup">
<iframe src="https://www.theguardian.com/email/form/plaintone/3887" height="42px" data-form-title="Sign up for Business Today" data-form-description="Get the headlines and editors' picks every weekday morning." scrolling="no" seamless="" frameborder="0" class="iframed--overflow-hidden email-sub__iframe js-email-sub__iframe js-email-sub__iframe--article" data-form-success-desc="Thanks for signing up" data-node-uid="2"></iframe>
<figcaption class="caption caption--img">
Sign up to the daily Business Today email or follow Guardian Business on Twitter at @BusinessDesk
</figcaption>
</figure>

This is rendered like below:

image

An atom type for these will allow editors to create reusable components for different email lists, reducing the chances that an email sign up box will be added signing users up to the wrong email (copying, pasting and editing the html is error prone!).

As an aside, the new atom should be rendered more like this:

Picture 59

TODO:

3: required string formDescription

// The exact target ID for the email list
4: required string emailListId
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need this - list name or list id

@amyhughes amyhughes merged commit 6d8fe6e into master Jan 21, 2020
@amyhughes amyhughes changed the title WIP: Add emailsignup atom Add emailsignup atom Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants