-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support typescript #140
Support typescript #140
Conversation
e7c707c
to
3b0557a
Compare
project/plugins.sbt
Outdated
|
||
addSbtPlugin("org.xerial.sbt" % "sbt-sonatype" % "3.7") | ||
|
||
addSbtPlugin("com.twitter" % "scrooge-sbt-plugin" % "19.9.0") | ||
addSbtPlugin("com.twitter" % "scrooge-sbt-plugin" % "20.4.0") | ||
addSbtPlugin("com.gu" % "sbt-scrooge-typescript" % "1.0.1") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to try this out!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's very early still :)
This is why we forked |
@mchv Yes I had a chat with @davidfurey yesterday who introduced me to French Thrift (which I believe is your creation?) So I'll look into it today |
3b0557a
to
2450f1d
Compare
This pull request now relies on the latest version of the scrooge-typescript plugin, which was completely re-written to generate the code from scala. I've tested it locally and the generated code compiles, including the generated imports. |
It seems to be working so far 😃 I'll merge and publish this one tomorrow morning |
This pull requests can be read commit by commit.
It:
renamesshared.thrift
toatomshared.thrift
as there is a namespace collision with the content-entity projectrenamesfrom
tomin
andto
tomax
asfrom
is a reserved word in thrift. This wasn't a problem as scrooge is more lax when it comes to the list of reserved wordsBefore merging I'll update the content-entity version to the latest once this PR (and the following one that will add typescript) has been approved