Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct default branch name for Snyk workflow #29

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

jfsoul
Copy link
Contributor

@jfsoul jfsoul commented Sep 9, 2022

Updates this repository's Snyk integration to use the correct branch name in the workflow trigger.

@jfsoul jfsoul requested review from a team as code owners September 9, 2022 16:00
@ParisaTork
Copy link
Contributor

ParisaTork commented Sep 9, 2022

Hi @jfsoul, we're going to master-to-main this repo on Monday - this repo had issues the last time it was master-to-mained and so it was switched back to master (see issue #28) - this revert took place after the Snyk integration (which specifies main as the target branch) - therefore, we're taking extra precautions with this one.

@jfsoul
Copy link
Contributor Author

jfsoul commented Sep 12, 2022

Thanks @ParisaTork, is this PR correct in keeping the Snyk org as CAPI's, or is #30 correct in updating it to be Ed tools'? I'll close one of them!

@ParisaTork
Copy link
Contributor

Hi @jfsoul :) I think content-entity is used by Ed Tools, CAPI and Dotcom, but if you fancy putting the org down as Ed Tools since we're sorting it, you're more than welcome to - equally, it would be fine if things stay the same and CAPI is listed as the Snyk org

@ParisaTork
Copy link
Contributor

This repo has been a finicky repo to m2m, so Snyk will point to master with this PR merge and the m2m-ing of this repo will occur later.

@jfsoul jfsoul merged commit c2be291 into master Sep 27, 2022
@jfsoul jfsoul deleted the nori/snyk-branch-update branch September 27, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants