Enable release checks back again #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we got successful releases after PR #38 we can now put back AssessedCompatibilityWithLatestReleas in our sbt file.
|
I think this is duplicated by #40 ! |
|
Yes, this PR is duplicate by #40 hence closing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we got successful releases after PR #38 we can now re-add "AssessedCompatibilityWithLatestRelease" check in the sbt file.
How to test
Make a new release once this PR gets merged.
This time Release process should be able to compare with previous release from maven for both
content-entity-modelandcontent-entity-thrift(which is at presentv3.0.2) and should be able to makev3.0.3release without any problem.How can we measure success?
New release should go ahead without any issue. (we should expect
v3.0.3once this PR gets merged).