Do not rewrite main
/module
if no exports
are present when bundling packages
#1167
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you changing?
#1122 added the ability to define multiple exports in packages, but it broke the build of packages which are not bundled by rollup, and removed
main
andmodule
fields from theirpackage.json
s. This fixes that.Note
There is some useful stuff in #114 that it would be good to bring across (esp breaking up the executor into separate compile/pack executors) that may help this, so this is just a fix to get it working
Why?
it's better when our packages work
fixes #1165