Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not rewrite main/module if no exports are present when bundling packages #1167

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

sndrs
Copy link
Member

@sndrs sndrs commented Feb 7, 2024

What are you changing?

#1122 added the ability to define multiple exports in packages, but it broke the build of packages which are not bundled by rollup, and removed main and module fields from their package.jsons. This fixes that.

Note

There is some useful stuff in #114 that it would be good to bring across (esp breaking up the executor into separate compile/pack executors) that may help this, so this is just a fix to get it working

Why?

it's better when our packages work

fixes #1165

@sndrs sndrs self-assigned this Feb 7, 2024
@sndrs sndrs requested a review from a team as a code owner February 7, 2024 12:57
Copy link

changeset-bot bot commented Feb 7, 2024

⚠️ No Changeset found

Latest commit: 37ad757

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 7, 2024

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@sndrs sndrs added the run_chromatic Runs chromatic when label is applied label Feb 7, 2024
@sndrs sndrs merged commit afdcd60 into main Feb 7, 2024
26 checks passed
@sndrs sndrs deleted the sndrs/fix-bundling branch February 7, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run_chromatic Runs chromatic when label is applied 🛠 workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm-package deleting main from package.json when building
2 participants