Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move chromatic into a reusable workflow #1189

Merged
merged 4 commits into from
Feb 9, 2024
Merged

Conversation

sndrs
Copy link
Member

@sndrs sndrs commented Feb 8, 2024

What are you changing?

  • pulls chromatic into a reusable workflow
  • uses it:
    • following a successful run of validate in CI
      • after a push to main
      • on PRs with the run_chromatic label
      • on PR from dependabot or changesets release bot
    • when a run_chromatic label is added to a PR

Why?

this should maintain the same level of chromatic coverage, but detaches CI from the labelling trigger in PRs

@sndrs sndrs requested a review from a team as a code owner February 8, 2024 15:24
Copy link

changeset-bot bot commented Feb 8, 2024

⚠️ No Changeset found

Latest commit: b86c0d5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 8, 2024

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@sndrs sndrs self-assigned this Feb 8, 2024
@sndrs sndrs force-pushed the sndrs/chromatic-improvements branch 2 times, most recently from f14634e to ad572cb Compare February 8, 2024 15:37
@sndrs sndrs added enhancement New feature or request run_chromatic Runs chromatic when label is applied labels Feb 8, 2024
@sndrs sndrs force-pushed the sndrs/workflow-improvements branch from 26b2847 to c9eaa8a Compare February 8, 2024 15:52
Base automatically changed from sndrs/workflow-improvements to main February 9, 2024 11:05
@sndrs sndrs force-pushed the sndrs/chromatic-improvements branch from 502d344 to b86c0d5 Compare February 9, 2024 11:11
@sndrs sndrs changed the title move changesets setup into common action Move chromatic setup into common action Feb 9, 2024
@sndrs sndrs changed the title Move chromatic setup into common action Move chromatic into a reusable workflow Feb 9, 2024
@sndrs sndrs enabled auto-merge (squash) February 9, 2024 11:13
Copy link
Contributor

@oliverabrahams oliverabrahams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sndrs sndrs merged commit b355bbe into main Feb 9, 2024
19 checks passed
@sndrs sndrs deleted the sndrs/chromatic-improvements branch February 9, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request run_chromatic Runs chromatic when label is applied
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants