-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add typography presets to Storybook #1272
Merged
jamesmockett
merged 19 commits into
jm/type-preset-release-branch
from
jm/storybook-type-presets
Mar 14, 2024
Merged
Add typography presets to Storybook #1272
jamesmockett
merged 19 commits into
jm/type-preset-release-branch
from
jm/storybook-type-presets
Mar 14, 2024
Commits on Mar 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 77881c9 - Browse repository at this point
Copy the full SHA 77881c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for a133afe - Browse repository at this point
Copy the full SHA a133afeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 867abbc - Browse repository at this point
Copy the full SHA 867abbcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 228268e - Browse repository at this point
Copy the full SHA 228268eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 064d634 - Browse repository at this point
Copy the full SHA 064d634View commit details -
Configuration menu - View commit details
-
Copy full SHA for 025a704 - Browse repository at this point
Copy the full SHA 025a704View commit details -
Configuration menu - View commit details
-
Copy full SHA for 179cc74 - Browse repository at this point
Copy the full SHA 179cc74View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e85ad4 - Browse repository at this point
Copy the full SHA 6e85ad4View commit details -
Configuration menu - View commit details
-
Copy full SHA for f9d8ff0 - Browse repository at this point
Copy the full SHA f9d8ff0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4630706 - Browse repository at this point
Copy the full SHA 4630706View commit details
Commits on Mar 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for eb03cd5 - Browse repository at this point
Copy the full SHA eb03cd5View commit details -
Export typography presets as CSS (#1270)
## What are you changing? - Adds built script to generate CSS for new [web typography presets](https://theguardian.design/2a1e5182b/p/01555f-typography-presets/b/830670) from the existing definitions in the design tokens package and export these as individual variables from Source Foundations - Updates some incorrect font sizes in the design tokens ```bash pnpm nx run @guardian/source-foundations:build-type-presets ``` ```json "textSansBold15": { "$value": { "fontFamily": "{typography.fontFamily.textSans}", "fontSize": "{typography.fontSize.15}", "lineHeight": "{typography.lineHeight.regular}", "fontWeight": "{typography.fontWeight.bold}", "fontStyle": "normal" } }, ``` ⬇️ ```tsx export const textSansBold15 = ` font-family: GuardianTextSans, "Guardian Text Sans Web", "Helvetica Neue", Helvetica, Arial, "Lucida Grande", sans-serif; font-size: 0.9375rem; line-height: 1.3; font-weight: 700; font-style: normal; `; ```
Configuration menu - View commit details
-
Copy full SHA for cc58a40 - Browse repository at this point
Copy the full SHA cc58a40View commit details -
Configuration menu - View commit details
-
Copy full SHA for c64629d - Browse repository at this point
Copy the full SHA c64629dView commit details
Commits on Mar 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c7b86b5 - Browse repository at this point
Copy the full SHA c7b86b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for abd1577 - Browse repository at this point
Copy the full SHA abd1577View commit details -
Configuration menu - View commit details
-
Copy full SHA for 20c99c6 - Browse repository at this point
Copy the full SHA 20c99c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 807c805 - Browse repository at this point
Copy the full SHA 807c805View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a87817 - Browse repository at this point
Copy the full SHA 9a87817View commit details
Commits on Mar 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2228658 - Browse repository at this point
Copy the full SHA 2228658View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.