Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typography presets to Storybook #1272

Merged
merged 19 commits into from
Mar 14, 2024

Commits on Mar 6, 2024

  1. Configuration menu
    Copy the full SHA
    77881c9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a133afe View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    867abbc View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    228268e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    064d634 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    025a704 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    179cc74 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    6e85ad4 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    f9d8ff0 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    4630706 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. Configuration menu
    Copy the full SHA
    eb03cd5 View commit details
    Browse the repository at this point in the history
  2. Export typography presets as CSS (#1270)

    ## What are you changing?
    
    - Adds built script to generate CSS for new [web typography
    presets](https://theguardian.design/2a1e5182b/p/01555f-typography-presets/b/830670)
    from the existing definitions in the design tokens package and export
    these as individual variables from Source Foundations
    - Updates some incorrect font sizes in the design tokens
    
    ```bash
    pnpm nx run @guardian/source-foundations:build-type-presets
    ```
    
    ```json
    "textSansBold15": {
      "$value": {
        "fontFamily": "{typography.fontFamily.textSans}",
        "fontSize": "{typography.fontSize.15}",
        "lineHeight": "{typography.lineHeight.regular}",
        "fontWeight": "{typography.fontWeight.bold}",
        "fontStyle": "normal"
      }
    },
    ```
    
    ⬇️
    
    ```tsx
    export const textSansBold15 = `
      font-family: GuardianTextSans, "Guardian Text Sans Web", "Helvetica Neue", Helvetica, Arial, "Lucida Grande", sans-serif;
      font-size: 0.9375rem;
      line-height: 1.3;
      font-weight: 700;
      font-style: normal;
    `;
    ```
    jamesmockett committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    cc58a40 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c64629d View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. Configuration menu
    Copy the full SHA
    c7b86b5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    abd1577 View commit details
    Browse the repository at this point in the history
  3. Fix invalid markup

    jamesmockett committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    20c99c6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    807c805 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9a87817 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. Configuration menu
    Copy the full SHA
    2228658 View commit details
    Browse the repository at this point in the history