Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecated export file and relocate deprecated code #1330

Merged
merged 4 commits into from
Apr 4, 2024

Conversation

jamesmockett
Copy link
Contributor

@jamesmockett jamesmockett commented Apr 3, 2024

What are you changing?

  • Relocates deprecated code to _deprecated folder and adds exports to deprecated-exports.ts.
  • Removes deprecated resets.input styles completely as these are now unused.

Why?

  • Having all deprecated code and exports in a single place makes it simpler to remove in the future. deprecated-exports.ts already exists in other packages so this is replicating the same pattern.

Copy link

changeset-bot bot commented Apr 3, 2024

⚠️ No Changeset found

Latest commit: 27f6741

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jamesmockett jamesmockett self-assigned this Apr 3, 2024
Copy link
Contributor

github-actions bot commented Apr 3, 2024

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@github-actions github-actions bot added the 📦 npm Affects a @guardian package on NPM label Apr 3, 2024
@jamesmockett jamesmockett changed the title Add deprecated export file and relocated deprecated code Add deprecated export file and relocate deprecated code Apr 3, 2024
@jamesmockett jamesmockett added the run_chromatic Runs chromatic when label is applied label Apr 3, 2024
@jamesmockett jamesmockett marked this pull request as ready for review April 3, 2024 16:35
@jamesmockett jamesmockett requested review from a team as code owners April 3, 2024 16:35
…ypes.ts

Co-authored-by: Alex Sanders <alex@sndrs.dev>
@jamesmockett jamesmockett merged commit 865665b into main Apr 4, 2024
20 checks passed
@jamesmockett jamesmockett deleted the jm/relocate-deprecated-code branch April 4, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 npm Affects a @guardian package on NPM run_chromatic Runs chromatic when label is applied
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants