Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean root deps #1484

Merged
merged 4 commits into from
May 23, 2024
Merged

Clean root deps #1484

merged 4 commits into from
May 23, 2024

Conversation

sndrs
Copy link
Member

@sndrs sndrs commented May 23, 2024

What are you changing?

  • remove's swc in favour of tsx
  • moves jest deps out of the root
    • and fixes config path for wireit inputs
  • remove uneccessary eslint deps

Why?

keep it clean

@sndrs sndrs requested review from a team as code owners May 23, 2024 14:49
Copy link

changeset-bot bot commented May 23, 2024

⚠️ No Changeset found

Latest commit: 3ddafbf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@sndrs sndrs added the run_chromatic Runs chromatic when label is applied label May 23, 2024
@sndrs sndrs enabled auto-merge (squash) May 23, 2024 14:50
@sndrs sndrs merged commit d2d5c6f into main May 23, 2024
21 checks passed
@sndrs sndrs deleted the sndrs/clean-deps branch May 23, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@guardian/ab-core @guardian/ab-react @guardian/libs 📦 npm Affects a @guardian package on NPM run_chromatic Runs chromatic when label is applied
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants