Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate from cypress to playwright #1510

Merged
merged 31 commits into from
Jun 11, 2024
Merged

migrate from cypress to playwright #1510

merged 31 commits into from
Jun 11, 2024

Conversation

oliverabrahams
Copy link
Contributor

@oliverabrahams oliverabrahams commented Jun 4, 2024 •
edited

What are you changing?

  • Replaced the cypress e2e tests with playwright

Why?

  • The cypress ones were quite slow and flakey

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 4, 2024 •
edited

⚠️ No Changeset found

Latest commit: c236f00

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 4, 2024

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@github-actions github-actions bot added 📦 npm Affects a @guardian package on NPM @guardian/libs labels Jun 4, 2024
@oliverabrahams oliverabrahams marked this pull request as ready for review June 5, 2024 12:35
@oliverabrahams oliverabrahams requested review from a team as code owners June 5, 2024 12:35
@oliverabrahams oliverabrahams added run_chromatic Runs chromatic when label is applied labels Jun 5, 2024
@oliverabrahams oliverabrahams requested a review from a team June 6, 2024 15:49
jamesmockett
jamesmockett approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@jamesmockett jamesmockett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the question about the e2e:ui task this looks good. Nice work 🎉

akinsola-guardian
akinsola-guardian approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@akinsola-guardian akinsola-guardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. This is a great improvement from the cypress test.

@sndrs sndrs mentioned this pull request Jun 10, 2024
Merged
sndrs
sndrs approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@sndrs sndrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so much nicer! great work

@sndrs sndrs merged commit e351b21 into main Jun 11, 2024
19 checks passed
@sndrs sndrs deleted the oa/playwright-v2 branch June 11, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesmockett jamesmockett jamesmockett approved these changes

@sndrs sndrs sndrs approved these changes

@akinsola-guardian akinsola-guardian akinsola-guardian approved these changes

Assignees
No one assigned
Labels
@guardian/libs 📦 npm Affects a @guardian package on NPM run_chromatic Runs chromatic when label is applied
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oliverabrahams @sndrs @jamesmockett @akinsola-guardian