Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename deprecated code folder #1517

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Rename deprecated code folder #1517

merged 1 commit into from
Jun 10, 2024

Conversation

jamesmockett
Copy link
Contributor

What are you changing?

  • Renames _deprecated → __deprecated__

Why?

  • To make if consistent with the __generated__ folder and harmonise the file tree view

@jamesmockett jamesmockett self-assigned this Jun 7, 2024
@jamesmockett jamesmockett requested review from a team as code owners June 7, 2024 16:29
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 7, 2024

⚠️ No Changeset found

Latest commit: 6653cac

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 7, 2024

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@jamesmockett jamesmockett added the run_chromatic Runs chromatic when label is applied label Jun 7, 2024
@github-actions github-actions bot added 📦 npm Affects a @guardian package on NPM and removed run_chromatic Runs chromatic when label is applied labels Jun 7, 2024
@jamesmockett jamesmockett added the run_chromatic Runs chromatic when label is applied label Jun 10, 2024
@jamesmockett jamesmockett merged commit 3afa5f3 into main Jun 10, 2024
23 checks passed
@jamesmockett jamesmockett deleted the jm/rename-deprecated-folder branch June 10, 2024 09:46
@jamesmockett jamesmockett mentioned this pull request Jun 10, 2024
Merged
jamesmockett added a commit that referenced this pull request Jun 10, 2024
@jamesmockett
Fix import order linting error (#1526)
517b213 
## What are you changing?

- Updates import order in token tests to fix linting error

## Why?

- #1517 renamed the deprecated code folder in Source Foundations, but
the import order was not updated to reflect this. This _should_ have
resulted in a broken build, but the linting task appears to have been
cached. The broken build is currently only apparent in Dependabot PRs
whilst the build on `main` appears to be fine with a green tick.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sndrs sndrs sndrs approved these changes

Assignees

@jamesmockett jamesmockett

Labels
📦 npm Affects a @guardian package on NPM run_chromatic Runs chromatic when label is applied
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jamesmockett @sndrs