Update Source icon set #1562
Merged
Update Source icon set #1562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7b159ce The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Tip Once this PR is ready to go, add the This saves us a lot of money by not running the tests before we need them. |
jamesmockett
force-pushed
the
jm/update-icon-set
branch
from
1221189
to
c4b1d14
Compare
jamesmockett
force-pushed
the
jm/update-icon-set
branch
from
3041392
to
282a4e1
Compare
jamesmockett
added
🐥 Canaries
jamesmockett
force-pushed
the
jm/update-icon-set
branch
from
dfc3c2c
to
d37e18a
Compare
|
Note The following canaries were published to NPM: 🐥 |
|
Note The following canaries were published to NPM: 🐥 |
jamesmockett
force-pushed
the
jm/update-icon-set
branch
from
d37e18a
to
19bcf68
Compare
jamesmockett
added
run_chromatic
jamesmockett
force-pushed
the
jm/update-icon-set
branch
from
c1501db
to
7ed81fd
Compare
jamesmockett
force-pushed
the
jm/update-icon-set
branch
from
7ed81fd
to
3d5d984
Compare
Definitely. I thought I'd added one, but seems not 😞 (Or somehow didn't commit it.) Will add now… |
jamesmockett
force-pushed
the
jm/update-icon-set
branch
2 times, most recently
from
909ba57
to
9aa5b85
Compare
Storybook's built-in icon gallery has some formatting issues due to the length of our icon names. Overlap occurs on wide screens, becoming worse as viewport width shrinks. It also forces all icons to be the same size so we cannot render them at one of our defined sizes, or render the wide payment icons at their natural size. Building our own custom gallery and styles allows us to work around these issues. By using the same names and props we can potentially switch back to the Storybook version in the future if these issues are resolved.
jamesmockett
force-pushed
the
jm/update-icon-set
branch
from
9aa5b85
to
7b159ce
Compare
SiAdcock
approved these changes
Jul 11, 2024
|
Usage of the renamed icons across projects looks like this:
(Note: this ignores usage of the old Usage of the previously deprecated and now removed icons is as follows:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you changing?
Renamed icons
The following icons have been renamed:
SvgBookMarkSvgBookmarkFilledSvgBookMarkCrossSvgBookmarkCrossSvgCrossRoundSvgCrossRoundFilledSvgHouseSvgHomeHouseFilledSvgPersonRoundSvgPersonRoundFilledSvgShareSvgShareWebDeprecated icons
The following deprecated aliases have been removed:
SvgOfflineCloudSvgCrossedOutCloudSvgAlertSvgExclamationSvgMessengerSvgFacebookMessengerSvgInfoSvgInfoRoundSvgPlaySvgMediaControlsPlaySvgPayPalSvgPayPalBrandeg. if you are importing
SvgOfflineCloudthis is aliased toSvgCrossedOutCloud. The alias has now been removed so you should importSvgCrossedOutClouddirectly.The following icons have also been deprecated and will be removed in a future release:
SvgAlertTriangleSvgAlertRoundSvgFilterSvgFilterOutlinedWebSvgShareCalloutSvgShareWebWhy?
Images
All icons
Icon gallery