Refactor timeAgo to make it more performant
#850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cff734b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
📦 npm
mxdvl
force-pushed
the
mxdvl/timeAgo
branch
2 times, most recently
from
809ba7c
to
7df1e47
Compare
jamesgorrie
approved these changes
Oct 16, 2023
abeddow91
reviewed
Oct 17, 2023
abeddow91
approved these changes
Oct 17, 2023
internal changes that result in a 20× speed up, which brings the execution from 1-2µs to 60-70ns
|
To clarify yak shaving, I meant in a good way: "An activity that allows one to overcome intermediate difficulties, which then allows one to solve a larger problem." As in avoiding death of a thousand papercuts on performance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you changing?
timeAgoreformatted the tests (unintentionally)→ Format@guardian/libswith Prettier #852Why?