Skip to content

Commit

Permalink
Merge pull request #11403 from guardian/ei/remove-commercial-mega-test
Browse files Browse the repository at this point in the history
Remove commercial mega test
  • Loading branch information
emma-imber committed May 13, 2024
2 parents a1111c4 + c01f507 commit 7bf3652
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 138 deletions.
11 changes: 1 addition & 10 deletions dotcom-rendering/src/lib/article.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,13 @@ import { enhanceCommercialProperties } from '../model/enhanceCommercialPropertie
import { enhanceStandfirst } from '../model/enhanceStandfirst';
import { enhanceTableOfContents } from '../model/enhanceTableOfContents';
import { validateAsArticleType } from '../model/validate';
import type { ServerSideTests } from '../types/config';
import { type DCRArticle } from '../types/frontend';
import { type RenderingTarget } from '../types/renderingTarget';
import { decideFormat } from './decideFormat';

const enhancePinnedPost = (
format: ArticleFormat,
renderingTarget: RenderingTarget,
abTests: ServerSideTests,
block?: Block,
) => {
if (!block) return;
Expand All @@ -24,7 +22,6 @@ const enhancePinnedPost = (
imagesForLightbox: [],
promotedNewsletter: undefined,
hasAffiliateLinksDisclaimer: false,
abTests,
})[0];
};

Expand All @@ -44,7 +41,6 @@ export const enhanceArticleType = (
promotedNewsletter: data.promotedNewsletter,
imagesForLightbox,
hasAffiliateLinksDisclaimer: !!data.affiliateLinksDisclaimer,
abTests: data.config.abTests,
});

const mainMediaElements = enhanceMainMedia(
Expand All @@ -57,12 +53,7 @@ export const enhanceArticleType = (
...data,
mainMediaElements,
blocks: enhancedBlocks,
pinnedPost: enhancePinnedPost(
format,
renderingTarget,
data.config.abTests,
data.pinnedPost,
),
pinnedPost: enhancePinnedPost(format, renderingTarget, data.pinnedPost),
standfirst: enhanceStandfirst(data.standfirst),
commercialProperties: enhanceCommercialProperties(
data.commercialProperties,
Expand Down
115 changes: 0 additions & 115 deletions dotcom-rendering/src/model/enhance-ad-placeholders_AB_TEST_CONTROL.ts

This file was deleted.

15 changes: 3 additions & 12 deletions dotcom-rendering/src/model/enhanceBlocks.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
import { type ArticleFormat } from '@guardian/libs';
import type { ServerSideTests } from '../types/config';
import type { FEElement, ImageForLightbox, Newsletter } from '../types/content';
import type { RenderingTarget } from '../types/renderingTarget';
import { enhanceAdPlaceholders } from './enhance-ad-placeholders';
import { enhanceAdPlaceholders as enhanceAdPlaceholders_AB_TEST_CONTROL } from './enhance-ad-placeholders_AB_TEST_CONTROL';
import { enhanceBlockquotes } from './enhance-blockquotes';
import { enhanceDisclaimer } from './enhance-disclaimer';
import { enhanceDividers } from './enhance-dividers';
Expand All @@ -24,7 +22,6 @@ type Options = {
promotedNewsletter: Newsletter | undefined;
imagesForLightbox: ImageForLightbox[];
hasAffiliateLinksDisclaimer: boolean;
abTests: ServerSideTests;
};

const enhanceNewsletterSignup =
Expand All @@ -48,8 +45,8 @@ const enhanceNewsletterSignup =
// as they both effect SubheadingBlockElement
export const enhanceElements =
(format: ArticleFormat, blockId: string, options: Options) =>
(elements: FEElement[]): FEElement[] => {
return [
(elements: FEElement[]): FEElement[] =>
[
enhanceLists(enhanceElements(format, blockId, options)),
enhanceTimeline(enhanceElements(format, blockId, options)),
enhanceDividers,
Expand All @@ -66,18 +63,12 @@ export const enhanceElements =
options.promotedNewsletter,
blockId,
),
options.abTests.commercialMegaTestControl === 'control'
? enhanceAdPlaceholders_AB_TEST_CONTROL(
format,
options.renderingTarget,
)
: enhanceAdPlaceholders(format, options.renderingTarget),
enhanceAdPlaceholders(format, options.renderingTarget),
enhanceDisclaimer(options.hasAffiliateLinksDisclaimer),
].reduce(
(enhancedBlocks, enhancer) => enhancer(enhancedBlocks),
elements,
);
};

export const enhanceMainMedia =
(
Expand Down
1 change: 0 additions & 1 deletion dotcom-rendering/src/server/handler.article.web.ts
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ export const handleBlocks: RequestHandler = ({ body }, res) => {
promotedNewsletter: undefined,
imagesForLightbox: [],
hasAffiliateLinksDisclaimer: false,
abTests: abTests ?? {},
});
const html = renderBlocks({
blocks: enhancedBlocks,
Expand Down

0 comments on commit 7bf3652

Please sign in to comment.