Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log hidden front containers on page load #11444

Merged
merged 8 commits into from
May 29, 2024
Merged

Log hidden front containers on page load #11444

merged 8 commits into from
May 29, 2024

Conversation

cemms1
Copy link
Contributor

@cemms1 cemms1 commented May 17, 2024 •
edited
Loading

Document link

What does this change?

When checking if users have preferences for hiding front containers, this PR adds functionality to log to Ophan which containers are configured to be hidden on the current front.

No calls to Ophan will be made if:

  • a user has local storage configuration to hide front containers, but had subsequently un-hidden them on the current front
  • a user has local storage configuration to hide front containers, but none of those container IDs match any on the current front
  • a user does not have any locally stored preferences to hide or show containers at all (has never interacted with the feature or wiped their browser storage)

Why?

We are interested to know how many people use the show/hide functionality on web fronts.

Having analysed how many page views result in a click to show/hide an individual container, we will try to quantify this further by assessing how many users have current preferences to hide containers on fronts.

Caveats

There are several problems with this approach. The local storage solution is quite naiive and simply saves the front ID as the object key with either "opened" or "closed" as the value.

  • This means that we can't say how recently the containers were hidden since local storage items do not expire.
  • We also can't yet say which front the container was hidden from, since some fronts share container names and hence "slug" IDs
    For example, if you hide the "spotlight" container on the UK network front, any other front with a container ID of "spotlight" will also appear hidden whether that was the initial intention or not.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 17, 2024 •
edited
Loading

Size Change: +57 B (+0.01%)

Total Size: 835 kB

ℹ️ View Unchanged
Filename Size Change
dotcom-rendering/dist/1006.client.web.********************.js 3.18 kB 0 B
dotcom-rendering/dist/1045.client.web.********************.js 12.5 kB 0 B
dotcom-rendering/dist/1094.client.web.********************.js 5.93 kB 0 B
dotcom-rendering/dist/110.client.web.********************.js 8.8 kB 0 B
dotcom-rendering/dist/1225.client.web.********************.js 781 B 0 B
dotcom-rendering/dist/1299.client.web.********************.js 926 B 0 B
dotcom-rendering/dist/1568.client.web.********************.js 18 kB 0 B
dotcom-rendering/dist/1640.client.web.********************.js 4.83 kB 0 B
dotcom-rendering/dist/1735.client.web.********************.js 2.42 kB 0 B
dotcom-rendering/dist/1762.client.web.********************.js 3.4 kB 0 B
dotcom-rendering/dist/1821.client.web.********************.js 3.83 kB 0 B
dotcom-rendering/dist/1889.client.web.********************.js 3.61 kB 0 B
dotcom-rendering/dist/2170.client.web.********************.js 6.75 kB 0 B
dotcom-rendering/dist/2193.client.web.********************.js 3.88 kB 0 B
dotcom-rendering/dist/226.client.web.********************.js 3.94 kB 0 B
dotcom-rendering/dist/2302.client.web.********************.js 3.39 kB 0 B
dotcom-rendering/dist/2342.client.web.********************.js 1 kB 0 B
dotcom-rendering/dist/2344.client.web.********************.js 3.35 kB 0 B
dotcom-rendering/dist/2373.client.web.********************.js 10.5 kB 0 B
dotcom-rendering/dist/2471.client.web.********************.js 715 B 0 B
dotcom-rendering/dist/2518.client.web.********************.js 2.66 kB 0 B
dotcom-rendering/dist/2778.client.web.********************.js 853 B 0 B
dotcom-rendering/dist/2784.client.web.********************.js 5.86 kB 0 B
dotcom-rendering/dist/2792.client.web.********************.js 6.41 kB 0 B
dotcom-rendering/dist/2813.client.web.********************.js 3.84 kB 0 B
dotcom-rendering/dist/2920.client.web.********************.js 526 B 0 B
dotcom-rendering/dist/3000.client.web.********************.js 887 B 0 B
dotcom-rendering/dist/3114.client.web.********************.js 651 B 0 B
dotcom-rendering/dist/3118.client.web.********************.js 496 B 0 B
dotcom-rendering/dist/3255.client.web.********************.js 803 B 0 B
dotcom-rendering/dist/3336.client.web.********************.js 781 B 0 B
dotcom-rendering/dist/3413.client.web.********************.js 3.58 kB 0 B
dotcom-rendering/dist/3494.client.web.********************.js 823 B 0 B
dotcom-rendering/dist/3642.client.web.********************.js 787 B 0 B
dotcom-rendering/dist/3787.client.web.********************.js 5.51 kB 0 B
dotcom-rendering/dist/3922.client.web.********************.js 724 B 0 B
dotcom-rendering/dist/3925.client.web.********************.js 4.79 kB 0 B
dotcom-rendering/dist/3927.client.web.********************.js 3.1 kB 0 B
dotcom-rendering/dist/3932.client.web.********************.js 789 B 0 B
dotcom-rendering/dist/4021.client.web.********************.js 4.29 kB 0 B
dotcom-rendering/dist/4103.client.web.********************.js 22.6 kB 0 B
dotcom-rendering/dist/42.client.web.********************.js 2.92 kB 0 B
dotcom-rendering/dist/4200.client.web.********************.js 3.58 kB 0 B
dotcom-rendering/dist/424.client.web.********************.js 749 B 0 B
dotcom-rendering/dist/4442.client.web.********************.js 823 B 0 B
dotcom-rendering/dist/4597.client.web.********************.js 2.98 kB 0 B
dotcom-rendering/dist/4666.client.web.********************.js 9.1 kB 0 B
dotcom-rendering/dist/4673.client.web.********************.js 723 B 0 B
dotcom-rendering/dist/4811.client.web.********************.js 994 B 0 B
dotcom-rendering/dist/4935.client.web.********************.js 3.5 kB 0 B
dotcom-rendering/dist/5027.client.web.********************.js 3.98 kB 0 B
dotcom-rendering/dist/5044.client.web.********************.js 804 B 0 B
dotcom-rendering/dist/5055.client.web.********************.js 2.65 kB 0 B
dotcom-rendering/dist/5077.client.web.********************.js 441 B 0 B
dotcom-rendering/dist/5084.client.web.********************.js 751 B 0 B
dotcom-rendering/dist/5247.client.web.********************.js 2.94 kB 0 B
dotcom-rendering/dist/5308.client.web.********************.js 2.7 kB 0 B
dotcom-rendering/dist/5339.client.web.********************.js 3.53 kB 0 B
dotcom-rendering/dist/5437.client.web.********************.js 3.29 kB 0 B
dotcom-rendering/dist/565.client.web.********************.js 669 B 0 B
dotcom-rendering/dist/5817.client.web.********************.js 915 B 0 B
dotcom-rendering/dist/585.client.web.********************.js 3.01 kB 0 B
dotcom-rendering/dist/5934.client.web.********************.js 8.25 kB 0 B
dotcom-rendering/dist/6002.client.web.********************.js 3.09 kB 0 B
dotcom-rendering/dist/6093.client.web.********************.js 749 B 0 B
dotcom-rendering/dist/6167.client.web.********************.js 640 B 0 B
dotcom-rendering/dist/6351.client.web.********************.js 6.09 kB 0 B
dotcom-rendering/dist/6640.client.web.********************.js 906 B 0 B
dotcom-rendering/dist/7116.client.web.********************.js 23 kB 0 B
dotcom-rendering/dist/7196.client.web.********************.js 889 B 0 B
dotcom-rendering/dist/72.client.web.********************.js 961 B 0 B
dotcom-rendering/dist/7270.client.web.********************.js 155 B 0 B
dotcom-rendering/dist/7387.client.web.********************.js 955 B 0 B
dotcom-rendering/dist/7660.client.web.********************.js 3.65 kB 0 B
dotcom-rendering/dist/7697.client.web.********************.js 619 B 0 B
dotcom-rendering/dist/7723.client.web.********************.js 921 B 0 B
dotcom-rendering/dist/7727.client.web.********************.js 3.34 kB 0 B
dotcom-rendering/dist/7740.client.web.********************.js 4.42 kB 0 B
dotcom-rendering/dist/8058.client.web.********************.js 3.22 kB 0 B
dotcom-rendering/dist/8134.client.web.********************.js 595 B 0 B
dotcom-rendering/dist/8179.client.web.********************.js 825 B 0 B
dotcom-rendering/dist/8239.client.web.********************.js 3 kB 0 B
dotcom-rendering/dist/8253.client.web.********************.js 5.87 kB 0 B
dotcom-rendering/dist/8279.client.web.********************.js 42.9 kB 0 B
dotcom-rendering/dist/8334.client.web.********************.js 3.3 kB 0 B
dotcom-rendering/dist/8565.client.web.********************.js 642 B 0 B
dotcom-rendering/dist/8677.client.web.********************.js 2.81 kB 0 B
dotcom-rendering/dist/8768.client.web.********************.js 1.54 kB 0 B
dotcom-rendering/dist/8791.client.web.********************.js 1 kB 0 B
dotcom-rendering/dist/889.client.web.********************.js 854 B 0 B
dotcom-rendering/dist/8907.client.web.********************.js 789 B 0 B
dotcom-rendering/dist/898.client.web.********************.js 4.43 kB 0 B
dotcom-rendering/dist/9060.client.web.********************.js 877 B 0 B
dotcom-rendering/dist/9211.client.web.********************.js 3.83 kB 0 B
dotcom-rendering/dist/9225.client.web.********************.js 582 B 0 B
dotcom-rendering/dist/9396.client.web.********************.js 680 B 0 B
dotcom-rendering/dist/9430.client.web.********************.js 508 B 0 B
dotcom-rendering/dist/9551.client.web.********************.js 4.3 kB 0 B
dotcom-rendering/dist/9604.client.web.********************.js 530 B 0 B
dotcom-rendering/dist/9732.client.web.********************.js 2.91 kB 0 B
dotcom-rendering/dist/9789.client.web.********************.js 922 B 0 B
dotcom-rendering/dist/9936.client.web.********************.js 1.85 kB 0 B
dotcom-rendering/dist/AdBlockAsk-importable.client.web.********************.js 2.85 kB 0 B
dotcom-rendering/dist/AdPortals-importable.client.web.********************.js 3.76 kB 0 B
dotcom-rendering/dist/AlreadyVisited-importable.client.web.********************.js 422 B 0 B
dotcom-rendering/dist/AppsEpic-importable.client.web.********************.js 3.52 kB 0 B
dotcom-rendering/dist/AppsFooter-importable.client.web.********************.js 3.62 kB 0 B
dotcom-rendering/dist/AppsLightboxImage-importable.client.web.********************.js 3.02 kB 0 B
dotcom-rendering/dist/AppsLightboxImageStore-importable.client.web.********************.js 2.46 kB 0 B
dotcom-rendering/dist/AudioAtomWrapper-importable.client.web.********************.js 3.58 kB 0 B
dotcom-rendering/dist/AustralianTerritorySwitcher-importable.client.web.********************.js 2.01 kB 0 B
dotcom-rendering/dist/Branding-importable.client.web.********************.js 3.08 kB 0 B
dotcom-rendering/dist/braze-web-sdk-core.client.web.********************.js 36.9 kB 0 B
dotcom-rendering/dist/BrazeMessaging-importable.client.web.********************.js 1.91 kB 0 B
dotcom-rendering/dist/CalloutBlockComponent-importable.client.web.********************.js 6.74 kB 0 B
dotcom-rendering/dist/CalloutEmbedBlockComponent-importable.client.web.********************.js 5.75 kB 0 B
dotcom-rendering/dist/CardCommentCount-importable.client.web.********************.js 4.96 kB 0 B
dotcom-rendering/dist/Carousel-importable.client.web.********************.js 5.7 kB 0 B
dotcom-rendering/dist/CarouselForNewsletters-importable.client.web.********************.js 6.26 kB 0 B
dotcom-rendering/dist/ChartAtom-importable.client.web.********************.js 537 B 0 B
dotcom-rendering/dist/CommentCount-importable.client.web.********************.js 3.27 kB 0 B
dotcom-rendering/dist/DiscussionApps-importable.client.web.********************.js 1.81 kB 0 B
dotcom-rendering/dist/DiscussionMeta-importable.client.web.********************.js 3.08 kB 0 B
dotcom-rendering/dist/DiscussionWeb-importable.client.web.********************.js 1.67 kB 0 B
dotcom-rendering/dist/DocumentBlockComponent-importable.client.web.********************.js 3.55 kB 0 B
dotcom-rendering/dist/EmbedBlockComponent-importable.client.web.********************.js 4.1 kB 0 B
dotcom-rendering/dist/EnhancePinnedPost-importable.client.web.********************.js 2.01 kB 0 B
dotcom-rendering/dist/FetchOnwardsData-importable.client.web.********************.js 2.44 kB 0 B
dotcom-rendering/dist/FilterKeyEventsToggle-importable.client.web.********************.js 5.23 kB 0 B
dotcom-rendering/dist/FocusStyles-importable.client.web.********************.js 623 B 0 B
dotcom-rendering/dist/FollowWrapper-importable.client.web.********************.js 845 B 0 B
dotcom-rendering/dist/FooterLabel-importable.client.web.********************.js 342 B 0 B
dotcom-rendering/dist/frameworks.client.web.********************.js 20.7 kB 0 B
dotcom-rendering/dist/GetCricketScoreboard-importable.client.web.********************.js 4.49 kB 0 B
dotcom-rendering/dist/GetMatchNav-importable.client.web.********************.js 10.9 kB 0 B
dotcom-rendering/dist/GetMatchStats-importable.client.web.********************.js 2.19 kB 0 B
dotcom-rendering/dist/GetMatchTabs-importable.client.web.********************.js 2.65 kB 0 B
dotcom-rendering/dist/guardian-braze-components-banner.client.web.********************.js 16.6 kB 0 B
dotcom-rendering/dist/guardian-braze-components-end-of-article.client.web.********************.js 11.1 kB 0 B
dotcom-rendering/dist/GuideAtomWrapper-importable.client.web.********************.js 3.01 kB 0 B
dotcom-rendering/dist/HeaderTopBar-importable.client.web.********************.js 7.05 kB 0 B
dotcom-rendering/dist/index.client.web.********************.js 46.8 kB -2 B (0%)
dotcom-rendering/dist/InstagramBlockComponent-importable.client.web.********************.js 3.65 kB 0 B
dotcom-rendering/dist/InteractiveAtomMessenger-importable.client.web.********************.js 854 B 0 B
dotcom-rendering/dist/InteractiveBlockComponent-importable.client.web.********************.js 6.28 kB 0 B
dotcom-rendering/dist/InteractiveContentsBlockComponent-importable.client.web.********************.js 4.66 kB 0 B
dotcom-rendering/dist/InteractiveSupportButton-importable.client.web.********************.js 3.48 kB 0 B
dotcom-rendering/dist/KeyEventsCarousel-importable.client.web.********************.js 4.85 kB 0 B
dotcom-rendering/dist/KnowledgeQuizAtom-importable.client.web.********************.js 3.5 kB 0 B
dotcom-rendering/dist/LatestLinks-importable.client.web.********************.js 4.26 kB 0 B
dotcom-rendering/dist/LightboxHash-importable.client.web.********************.js 434 B 0 B
dotcom-rendering/dist/LightboxLayout-importable.client.web.********************.js 6.43 kB 0 B
dotcom-rendering/dist/LiveBlogEpic-importable.client.web.********************.js 3.69 kB 0 B
dotcom-rendering/dist/Liveness-importable.client.web.********************.js 4.93 kB 0 B
dotcom-rendering/dist/ManyNewsletterSignUp-importable.client.web.********************.js 5.95 kB 0 B
dotcom-rendering/dist/MapEmbedBlockComponent-importable.client.web.********************.js 5.75 kB 0 B
dotcom-rendering/dist/Metrics-importable.client.web.********************.js 2.97 kB 0 B
dotcom-rendering/dist/MostViewedFooter-importable.client.web.********************.js 4.03 kB 0 B
dotcom-rendering/dist/MostViewedFooterData-importable.client.web.********************.js 6.72 kB 0 B
dotcom-rendering/dist/MostViewedRightWrapper-importable.client.web.********************.js 4.88 kB 0 B
dotcom-rendering/dist/OnwardsUpper-importable.client.web.********************.js 4.08 kB 0 B
dotcom-rendering/dist/PersonalityQuizAtom-importable.client.web.********************.js 3.63 kB 0 B
dotcom-rendering/dist/ProfileAtom-importable.client.web.********************.js 2.8 kB 0 B
dotcom-rendering/dist/ProfileAtomWrapper-importable.client.web.********************.js 3.03 kB 0 B
dotcom-rendering/dist/PulsingDot-importable.client.web.********************.js 750 B 0 B
dotcom-rendering/dist/QandaAtom-importable.client.web.********************.js 2.79 kB 0 B
dotcom-rendering/dist/ReaderRevenueDev-importable.client.web.********************.js 469 B 0 B
dotcom-rendering/dist/readerRevenueDevUtils.client.web.********************.js 1.89 kB 0 B
dotcom-rendering/dist/ReaderRevenueLinks-importable.client.web.********************.js 6.35 kB 0 B
dotcom-rendering/dist/RelativeTime-importable.client.web.********************.js 1.99 kB 0 B
dotcom-rendering/dist/RichLinkComponent-importable.client.web.********************.js 4.8 kB 0 B
dotcom-rendering/dist/SecureSignup-importable.client.web.********************.js 4.46 kB 0 B
dotcom-rendering/dist/SendAMessage-importable.client.web.********************.js 4.43 kB 0 B
dotcom-rendering/dist/SendTargetingParams-importable.client.web.********************.js 2.14 kB 0 B
dotcom-rendering/dist/sentry.client.web.********************.js 765 B 0 B
dotcom-rendering/dist/SetABTests-importable.client.web.********************.js 3.77 kB 0 B
dotcom-rendering/dist/SetAdTargeting-importable.client.web.********************.js 484 B 0 B
dotcom-rendering/dist/ShareButton-importable.client.web.********************.js 1.52 kB 0 B
dotcom-rendering/dist/shimport.client.web.********************.js 2.79 kB 0 B
dotcom-rendering/dist/ShowHideContainers-importable.client.web.********************.js 707 B +59 B (+9.1%) 🔍
dotcom-rendering/dist/ShowMore-importable.client.web.********************.js 5.73 kB 0 B
dotcom-rendering/dist/SignInGateCustomizableText.client.web.********************.js 3.66 kB 0 B
dotcom-rendering/dist/SignInGateMain.client.web.********************.js 3.9 kB 0 B
dotcom-rendering/dist/SignInGateMainCheckoutComplete.client.web.********************.js 3.95 kB 0 B
dotcom-rendering/dist/SignInGateSelector-importable.client.web.********************.js 3.81 kB 0 B
dotcom-rendering/dist/SlotBodyEnd-importable.client.web.********************.js 4.14 kB 0 B
dotcom-rendering/dist/SpotifyBlockComponent-importable.client.web.********************.js 5.59 kB 0 B
dotcom-rendering/dist/StickyBottomBanner-importable.client.web.********************.js 3.94 kB 0 B
dotcom-rendering/dist/SubNav-importable.client.web.********************.js 3.25 kB 0 B
dotcom-rendering/dist/SupportTheG-importable.client.web.********************.js 6.48 kB 0 B
dotcom-rendering/dist/TableOfContents-importable.client.web.********************.js 3.16 kB 0 B
dotcom-rendering/dist/TimelineAtom-importable.client.web.********************.js 3.23 kB 0 B
dotcom-rendering/dist/TopBar-importable.client.web.********************.js 5.01 kB 0 B
dotcom-rendering/dist/TopBarSupport-importable.client.web.********************.js 2.76 kB 0 B
dotcom-rendering/dist/TweetBlockComponent-importable.client.web.********************.js 1.02 kB 0 B
dotcom-rendering/dist/UnsafeEmbedBlockComponent-importable.client.web.********************.js 3.66 kB 0 B
dotcom-rendering/dist/VideoFacebookBlockComponent-importable.client.web.********************.js 5.76 kB 0 B
dotcom-rendering/dist/VineBlockComponent-importable.client.web.********************.js 3.49 kB 0 B
dotcom-rendering/dist/WeatherWrapper-importable.client.web.********************.js 5.52 kB 0 B
dotcom-rendering/dist/YoutubeBlockComponent-importable.client.web.********************.js 3.32 kB 0 B

compressed-size-action

@cemms1 cemms1 force-pushed the cemms1/ophan-record-hidden-containers branch from 4bd840a to 62c8fb0 Compare May 21, 2024 16:49
@github-actions GitHub Actions
Copy link

github-actions bot commented May 21, 2024 •
edited
Loading

Deploy build 34641 of Mobile::mobile-apps-rendering to CODE

All deployment options

From guardian/actions-riff-raff.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 21, 2024 •
edited
Loading

Deploy build 10535 of dotcom:rendering-all to CODE

All deployment options

From guardian/actions-riff-raff.

@cemms1 cemms1 force-pushed the cemms1/ophan-record-hidden-containers branch 2 times, most recently from 3485461 to bb483cc Compare May 28, 2024 10:00
@cemms1 cemms1 changed the title Add logic to record existence of hidden front containers on page load Log hidden front containers on page load May 28, 2024
@cemms1 cemms1 force-pushed the cemms1/ophan-record-hidden-containers branch from 747297d to 08615d8 Compare May 29, 2024 10:13
@cemms1 cemms1 added the run_chromatic Runs chromatic when label is applied label May 29, 2024
@cemms1 cemms1 marked this pull request as ready for review May 29, 2024 11:07
@cemms1 cemms1 requested a review from a team as a code owner May 29, 2024 11:07
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label May 29, 2024
DanielCliftonGuardian
DanielCliftonGuardian approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@DanielCliftonGuardian DanielCliftonGuardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@cemms1 cemms1 merged commit b795a33 into main May 29, 2024
33 checks passed
@cemms1 cemms1 deleted the cemms1/ophan-record-hidden-containers branch May 29, 2024 13:26
@prout-bot
Copy link

Seen on PROD (merged by @cemms1 10 minutes and 51 seconds ago) Please check your changes!

@cemms1 cemms1 mentioned this pull request Jul 2, 2024
Open
@cemms1 cemms1 mentioned this pull request Jul 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielCliftonGuardian DanielCliftonGuardian DanielCliftonGuardian approved these changes

Assignees
No one assigned
Labels
dotcom-rendering fairground Seen-on-PROD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cemms1 @prout-bot @DanielCliftonGuardian