Use https for videos hosted on cdn.theguardian.tv #11690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielCliftonGuardian
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Size Change: 0 B Total Size: 842 kB ℹ️ View Unchanged
|
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
mxdvl
approved these changes
Jun 20, 2024
DanielCliftonGuardian
added
the
run_chromatic
github-actions
bot
removed
the
run_chromatic
|
Seen on PROD (merged by @DanielCliftonGuardian 8 minutes and 39 seconds ago) Please check your changes! |
mxdvl
reviewed
Jun 21, 2024
| @@ -24,10 +24,14 @@ export const GuVideoBlockComponent = ({ | |||
| width: 100%; | |||
| } | |||
| `; | |||
|
|
|||
| const httpsHtml = html.replaceAll( | |||
| new RegExp('http://cdn\\.theguardian\\.tv', 'g'), | |||
There was a problem hiding this comment.
Could we not use a simple string rather than a regular expression, here?
frederickobrien
pushed a commit
that referenced
this pull request
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This adds a find and replace to switch to using https.
There is a function in frontend which attempts to do this but does not work for many videos as they return empty html strings. https://github.com/guardian/frontend/blob/99c59732f934d181c4ccc43b766558b93dfdeae2/common/app/model/dotcomrendering/pageElements/PageElement.scala#L1021
This should be done upstream however. See https://github.com/guardian/fastly-edge-cache/pull/880 and also for context https://github.com/guardian/content-api/pull/1395
Why?
Videos not playing due to csp rule.
Fixes #11599
Screenshots