Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Align contributions service URL logic in page layouts" #11931

Closed
wants to merge 1 commit into from
Closed

Revert "Align contributions service URL logic in page layouts" #11931

wants to merge 1 commit into from

Conversation

cemms1
Copy link
Contributor

@cemms1 cemms1 commented Jul 19, 2024

Reverts #11929 while investigating an issue

@cemms1 cemms1 added the run_chromatic Runs chromatic when label is applied label Jul 19, 2024
@github-actions GitHub Actions
Copy link

Deploy build 35997 of Mobile::mobile-apps-rendering to CODE

All deployment options

From guardian/actions-riff-raff.

@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Jul 19, 2024
@github-actions GitHub Actions
Copy link

Size Change: -65 B (-0.01%)

Total Size: 893 kB

ℹ️ View Unchanged
Filename Size Change
dotcom-rendering/dist/1000.client.web.********************.js 999 B 0 B
dotcom-rendering/dist/1026.client.web.********************.js 784 B 0 B
dotcom-rendering/dist/1027.client.web.********************.js 4.68 kB 0 B
dotcom-rendering/dist/1090.client.web.********************.js 752 B 0 B
dotcom-rendering/dist/1207.client.web.********************.js 22.6 kB 0 B
dotcom-rendering/dist/1391.client.web.********************.js 725 B 0 B
dotcom-rendering/dist/143.client.web.********************.js 157 B 0 B
dotcom-rendering/dist/1476.client.web.********************.js 784 B 0 B
dotcom-rendering/dist/1656.client.web.********************.js 527 B 0 B
dotcom-rendering/dist/1667.client.web.********************.js 918 B 0 B
dotcom-rendering/dist/1765.client.web.********************.js 617 B 0 B
dotcom-rendering/dist/1940.client.web.********************.js 507 B 0 B
dotcom-rendering/dist/2037.client.web.********************.js 2.67 kB 0 B
dotcom-rendering/dist/2247.client.web.********************.js 2.52 kB 0 B
dotcom-rendering/dist/2283.client.web.********************.js 3.47 kB 0 B
dotcom-rendering/dist/2309.client.web.********************.js 43.1 kB 0 B
dotcom-rendering/dist/2310.client.web.********************.js 880 B 0 B
dotcom-rendering/dist/2510.client.web.********************.js 3.21 kB 0 B
dotcom-rendering/dist/2584.client.web.********************.js 6.42 kB 0 B
dotcom-rendering/dist/267.client.web.********************.js 917 B 0 B
dotcom-rendering/dist/281.client.web.********************.js 642 B 0 B
dotcom-rendering/dist/2920.client.web.********************.js 3.67 kB 0 B
dotcom-rendering/dist/2935.client.web.********************.js 6.69 kB 0 B
dotcom-rendering/dist/3109.client.web.********************.js 803 B 0 B
dotcom-rendering/dist/3270.client.web.********************.js 961 B 0 B
dotcom-rendering/dist/3304.client.web.********************.js 853 B 0 B
dotcom-rendering/dist/3441.client.web.********************.js 4.3 kB 0 B
dotcom-rendering/dist/3630.client.web.********************.js 2.81 kB 0 B
dotcom-rendering/dist/3683.client.web.********************.js 4.61 kB 0 B
dotcom-rendering/dist/3726.client.web.********************.js 9.49 kB 0 B
dotcom-rendering/dist/3733.client.web.********************.js 3.54 kB 0 B
dotcom-rendering/dist/3769.client.web.********************.js 999 B 0 B
dotcom-rendering/dist/385.client.web.********************.js 4.5 kB 0 B
dotcom-rendering/dist/3921.client.web.********************.js 3.03 kB 0 B
dotcom-rendering/dist/4181.client.web.********************.js 3.83 kB 0 B
dotcom-rendering/dist/4195.client.web.********************.js 6.41 kB 0 B
dotcom-rendering/dist/4282.client.web.********************.js 685 B 0 B
dotcom-rendering/dist/4283.client.web.********************.js 3.41 kB 0 B
dotcom-rendering/dist/4305.client.web.********************.js 4.07 kB 0 B
dotcom-rendering/dist/4465.client.web.********************.js 3 kB 0 B
dotcom-rendering/dist/4628.client.web.********************.js 654 B 0 B
dotcom-rendering/dist/4662.client.web.********************.js 3.11 kB 0 B
dotcom-rendering/dist/4743.client.web.********************.js 3.99 kB 0 B
dotcom-rendering/dist/4772.client.web.********************.js 1.84 kB 0 B
dotcom-rendering/dist/4941.client.web.********************.js 890 B 0 B
dotcom-rendering/dist/5158.client.web.********************.js 3.42 kB 0 B
dotcom-rendering/dist/5308.client.web.********************.js 2.69 kB 0 B
dotcom-rendering/dist/5558.client.web.********************.js 3.4 kB 0 B
dotcom-rendering/dist/5658.client.web.********************.js 750 B 0 B
dotcom-rendering/dist/5757.client.web.********************.js 931 B 0 B
dotcom-rendering/dist/5880.client.web.********************.js 828 B 0 B
dotcom-rendering/dist/5925.client.web.********************.js 11.3 kB 0 B
dotcom-rendering/dist/6044.client.web.********************.js 726 B 0 B
dotcom-rendering/dist/6071.client.web.********************.js 577 B 0 B
dotcom-rendering/dist/6135.client.web.********************.js 779 B 0 B
dotcom-rendering/dist/647.client.web.********************.js 6.52 kB 0 B
dotcom-rendering/dist/6505.client.web.********************.js 1 kB 0 B
dotcom-rendering/dist/6598.client.web.********************.js 780 B 0 B
dotcom-rendering/dist/6605.client.web.********************.js 4.16 kB 0 B
dotcom-rendering/dist/6638.client.web.********************.js 907 B 0 B
dotcom-rendering/dist/6687.client.web.********************.js 7.29 kB 0 B
dotcom-rendering/dist/678.client.web.********************.js 804 B 0 B
dotcom-rendering/dist/6838.client.web.********************.js 3.09 kB 0 B
dotcom-rendering/dist/7069.client.web.********************.js 2.93 kB 0 B
dotcom-rendering/dist/7116.client.web.********************.js 23 kB 0 B
dotcom-rendering/dist/7280.client.web.********************.js 4.21 kB 0 B
dotcom-rendering/dist/7291.client.web.********************.js 4.84 kB -11 B (-0.23%)
dotcom-rendering/dist/7413.client.web.********************.js 2.23 kB 0 B
dotcom-rendering/dist/7447.client.web.********************.js 3.07 kB 0 B
dotcom-rendering/dist/7678.client.web.********************.js 3.2 kB 0 B
dotcom-rendering/dist/7691.client.web.********************.js 853 B 0 B
dotcom-rendering/dist/7891.client.web.********************.js 4.39 kB 0 B
dotcom-rendering/dist/80.client.web.********************.js 2.29 kB 0 B
dotcom-rendering/dist/8169.client.web.********************.js 441 B 0 B
dotcom-rendering/dist/83.client.web.********************.js 750 B 0 B
dotcom-rendering/dist/8325.client.web.********************.js 5.85 kB 0 B
dotcom-rendering/dist/8356.client.web.********************.js 13.5 kB 0 B
dotcom-rendering/dist/8504.client.web.********************.js 827 B 0 B
dotcom-rendering/dist/8524.client.web.********************.js 525 B 0 B
dotcom-rendering/dist/8536.client.web.********************.js 595 B 0 B
dotcom-rendering/dist/854.client.web.********************.js 3.34 kB 0 B
dotcom-rendering/dist/8566.client.web.********************.js 12.4 kB 0 B
dotcom-rendering/dist/8626.client.web.********************.js 890 B 0 B
dotcom-rendering/dist/8664.client.web.********************.js 3.22 kB 0 B
dotcom-rendering/dist/8670.client.web.********************.js 4.3 kB 0 B
dotcom-rendering/dist/8695.client.web.********************.js 3.63 kB 0 B
dotcom-rendering/dist/8697.client.web.********************.js 956 B 0 B
dotcom-rendering/dist/8716.client.web.********************.js 19.7 kB 0 B
dotcom-rendering/dist/8768.client.web.********************.js 3.57 kB 0 B
dotcom-rendering/dist/8833.client.web.********************.js 829 B 0 B
dotcom-rendering/dist/8916.client.web.********************.js 2.95 kB 0 B
dotcom-rendering/dist/8966.client.web.********************.js 5.13 kB 0 B
dotcom-rendering/dist/8995.client.web.********************.js 2.42 kB 0 B
dotcom-rendering/dist/901.client.web.********************.js 9.19 kB 0 B
dotcom-rendering/dist/9184.client.web.********************.js 493 B 0 B
dotcom-rendering/dist/9285.client.web.********************.js 6.17 kB 0 B
dotcom-rendering/dist/931.client.web.********************.js 3.05 kB 0 B
dotcom-rendering/dist/9493.client.web.********************.js 785 B 0 B
dotcom-rendering/dist/953.client.web.********************.js 6.29 kB 0 B
dotcom-rendering/dist/9557.client.web.********************.js 921 B 0 B
dotcom-rendering/dist/9721.client.web.********************.js 717 B 0 B
dotcom-rendering/dist/974.client.web.********************.js 5.49 kB 0 B
dotcom-rendering/dist/9835.client.web.********************.js 647 B 0 B
dotcom-rendering/dist/9899.client.web.********************.js 669 B 0 B
dotcom-rendering/dist/Accessibility-importable.client.web.********************.js 6.18 kB 0 B
dotcom-rendering/dist/AdBlockAsk-importable.client.web.********************.js 2.85 kB 0 B
dotcom-rendering/dist/AdPortals-importable.client.web.********************.js 3.84 kB 0 B
dotcom-rendering/dist/AlreadyVisited-importable.client.web.********************.js 424 B 0 B
dotcom-rendering/dist/AppsEpic-importable.client.web.********************.js 3.54 kB 0 B
dotcom-rendering/dist/AppsFooter-importable.client.web.********************.js 3.63 kB 0 B
dotcom-rendering/dist/AppsLightboxImage-importable.client.web.********************.js 3.03 kB 0 B
dotcom-rendering/dist/AppsLightboxImageStore-importable.client.web.********************.js 2.47 kB 0 B
dotcom-rendering/dist/AudioAtomWrapper-importable.client.web.********************.js 3.57 kB 0 B
dotcom-rendering/dist/AustralianTerritorySwitcher-importable.client.web.********************.js 2.34 kB 0 B
dotcom-rendering/dist/Branding-importable.client.web.********************.js 3.07 kB 0 B
dotcom-rendering/dist/braze-web-sdk-core.client.web.********************.js 37.2 kB 0 B
dotcom-rendering/dist/BrazeMessaging-importable.client.web.********************.js 1.95 kB 0 B
dotcom-rendering/dist/CalloutBlockComponent-importable.client.web.********************.js 6.71 kB 0 B
dotcom-rendering/dist/CalloutEmbedBlockComponent-importable.client.web.********************.js 5.75 kB 0 B
dotcom-rendering/dist/CardCommentCount-importable.client.web.********************.js 4.94 kB 0 B
dotcom-rendering/dist/Carousel-importable.client.web.********************.js 5.99 kB 0 B
dotcom-rendering/dist/CarouselForNewsletters-importable.client.web.********************.js 6.85 kB 0 B
dotcom-rendering/dist/ChartAtom-importable.client.web.********************.js 537 B 0 B
dotcom-rendering/dist/CommentCount-importable.client.web.********************.js 3.3 kB 0 B
dotcom-rendering/dist/DiscussionApps-importable.client.web.********************.js 1.81 kB 0 B
dotcom-rendering/dist/DiscussionMeta-importable.client.web.********************.js 1.21 kB 0 B
dotcom-rendering/dist/DiscussionWeb-importable.client.web.********************.js 1.73 kB 0 B
dotcom-rendering/dist/DocumentBlockComponent-importable.client.web.********************.js 3.65 kB 0 B
dotcom-rendering/dist/EditionSwitcherBanner-importable.client.web.********************.js 6.49 kB 0 B
dotcom-rendering/dist/EmbedBlockComponent-importable.client.web.********************.js 3.75 kB 0 B
dotcom-rendering/dist/EnhancePinnedPost-importable.client.web.********************.js 2.02 kB 0 B
dotcom-rendering/dist/FetchOnwardsData-importable.client.web.********************.js 2.43 kB 0 B
dotcom-rendering/dist/FilterKeyEventsToggle-importable.client.web.********************.js 5.21 kB 0 B
dotcom-rendering/dist/FocusStyles-importable.client.web.********************.js 623 B 0 B
dotcom-rendering/dist/FollowWrapper-importable.client.web.********************.js 3.37 kB 0 B
dotcom-rendering/dist/FooterLabel-importable.client.web.********************.js 346 B 0 B
dotcom-rendering/dist/FooterReaderRevenueLinks-importable.client.web.********************.js 3.68 kB -6 B (-0.16%)
dotcom-rendering/dist/frameworks.client.web.********************.js 20.7 kB 0 B
dotcom-rendering/dist/FrontSubNav-importable.client.web.********************.js 6.47 kB 0 B
dotcom-rendering/dist/GetCricketScoreboard-importable.client.web.********************.js 4.41 kB 0 B
dotcom-rendering/dist/GetMatchNav-importable.client.web.********************.js 10.4 kB 0 B
dotcom-rendering/dist/GetMatchStats-importable.client.web.********************.js 7.95 kB 0 B
dotcom-rendering/dist/GetMatchTabs-importable.client.web.********************.js 2.71 kB 0 B
dotcom-rendering/dist/guardian-braze-components-banner.client.web.********************.js 16.8 kB 0 B
dotcom-rendering/dist/guardian-braze-components-end-of-article.client.web.********************.js 11 kB 0 B
dotcom-rendering/dist/GuideAtomWrapper-importable.client.web.********************.js 3.01 kB 0 B
dotcom-rendering/dist/HeaderTopBar-importable.client.web.********************.js 7.65 kB 0 B
dotcom-rendering/dist/index.client.web.********************.js 45.9 kB +1 B (0%)
dotcom-rendering/dist/InstagramBlockComponent-importable.client.web.********************.js 3.29 kB 0 B
dotcom-rendering/dist/InteractiveAtomMessenger-importable.client.web.********************.js 852 B 0 B
dotcom-rendering/dist/InteractiveBlockComponent-importable.client.web.********************.js 6.3 kB 0 B
dotcom-rendering/dist/InteractiveContentsBlockComponent-importable.client.web.********************.js 4.68 kB 0 B
dotcom-rendering/dist/InteractiveSupportButton-importable.client.web.********************.js 6.7 kB -6 B (-0.09%)
dotcom-rendering/dist/KeyEventsCarousel-importable.client.web.********************.js 4.74 kB 0 B
dotcom-rendering/dist/KnowledgeQuizAtom-importable.client.web.********************.js 3.49 kB 0 B
dotcom-rendering/dist/LatestLinks-importable.client.web.********************.js 3.63 kB 0 B
dotcom-rendering/dist/LightboxHash-importable.client.web.********************.js 435 B 0 B
dotcom-rendering/dist/LightboxLayout-importable.client.web.********************.js 6.47 kB 0 B
dotcom-rendering/dist/LiveBlogEpic-importable.client.web.********************.js 3.72 kB -6 B (-0.16%)
dotcom-rendering/dist/Liveness-importable.client.web.********************.js 5 kB 0 B
dotcom-rendering/dist/ManyNewsletterSignUp-importable.client.web.********************.js 9.76 kB 0 B
dotcom-rendering/dist/MapEmbedBlockComponent-importable.client.web.********************.js 5.45 kB 0 B
dotcom-rendering/dist/Metrics-importable.client.web.********************.js 2.96 kB 0 B
dotcom-rendering/dist/MostViewedFooter-importable.client.web.********************.js 5.95 kB 0 B
dotcom-rendering/dist/MostViewedFooterData-importable.client.web.********************.js 8.57 kB 0 B
dotcom-rendering/dist/MostViewedRightWithAd-importable.client.web.********************.js 4.69 kB 0 B
dotcom-rendering/dist/OnwardsUpper-importable.client.web.********************.js 6.58 kB 0 B
dotcom-rendering/dist/PersonalityQuizAtom-importable.client.web.********************.js 3.63 kB 0 B
dotcom-rendering/dist/ProfileAtom-importable.client.web.********************.js 2.79 kB 0 B
dotcom-rendering/dist/ProfileAtomWrapper-importable.client.web.********************.js 3.03 kB 0 B
dotcom-rendering/dist/PulsingDot-importable.client.web.********************.js 748 B 0 B
dotcom-rendering/dist/QandaAtom-importable.client.web.********************.js 2.79 kB 0 B
dotcom-rendering/dist/ReaderRevenueDev-importable.client.web.********************.js 468 B 0 B
dotcom-rendering/dist/readerRevenueDevUtils.client.web.********************.js 1.92 kB -6 B (-0.31%)
dotcom-rendering/dist/RelativeTime-importable.client.web.********************.js 2.51 kB 0 B
dotcom-rendering/dist/RichLinkComponent-importable.client.web.********************.js 5.22 kB 0 B
dotcom-rendering/dist/SecureSignup-importable.client.web.********************.js 5.11 kB 0 B
dotcom-rendering/dist/SendTargetingParams-importable.client.web.********************.js 2.15 kB 0 B
dotcom-rendering/dist/sentry.client.web.********************.js 768 B 0 B
dotcom-rendering/dist/SetABTests-importable.client.web.********************.js 3.73 kB 0 B
dotcom-rendering/dist/SetAdTargeting-importable.client.web.********************.js 486 B 0 B
dotcom-rendering/dist/ShareButton-importable.client.web.********************.js 1.52 kB 0 B
dotcom-rendering/dist/shimport.client.web.********************.js 2.8 kB 0 B
dotcom-rendering/dist/ShowHideContainers-importable.client.web.********************.js 642 B 0 B
dotcom-rendering/dist/ShowMore-importable.client.web.********************.js 1.4 kB 0 B
dotcom-rendering/dist/SignInGateMain.client.web.********************.js 3.99 kB 0 B
dotcom-rendering/dist/SignInGateMainCheckoutComplete.client.web.********************.js 3.92 kB 0 B
dotcom-rendering/dist/SignInGateSelector-importable.client.web.********************.js 3.15 kB 0 B
dotcom-rendering/dist/SlotBodyEnd-importable.client.web.********************.js 3.46 kB 0 B
dotcom-rendering/dist/SpotifyBlockComponent-importable.client.web.********************.js 5.29 kB 0 B
dotcom-rendering/dist/StickyBottomBanner-importable.client.web.********************.js 4.08 kB 0 B
dotcom-rendering/dist/StickyLiveblogAskWrapper-importable.client.web.********************.js 7.95 kB -9 B (-0.11%)
dotcom-rendering/dist/SubNav-importable.client.web.********************.js 3.37 kB 0 B
dotcom-rendering/dist/SupportTheG-importable.client.web.********************.js 6.52 kB -11 B (-0.17%)
dotcom-rendering/dist/TableOfContents-importable.client.web.********************.js 3.19 kB 0 B
dotcom-rendering/dist/TimelineAtom-importable.client.web.********************.js 3.22 kB 0 B
dotcom-rendering/dist/TopBar-importable.client.web.********************.js 5.26 kB -4 B (-0.08%)
dotcom-rendering/dist/TopBarSupport-importable.client.web.********************.js 2.7 kB -7 B (-0.26%)
dotcom-rendering/dist/TweetBlockComponent-importable.client.web.********************.js 1.02 kB 0 B
dotcom-rendering/dist/UnsafeEmbedBlockComponent-importable.client.web.********************.js 3.3 kB 0 B
dotcom-rendering/dist/VideoFacebookBlockComponent-importable.client.web.********************.js 5.46 kB 0 B
dotcom-rendering/dist/VineBlockComponent-importable.client.web.********************.js 3.13 kB 0 B
dotcom-rendering/dist/WeatherWrapper-importable.client.web.********************.js 6.72 kB 0 B
dotcom-rendering/dist/YoutubeBlockComponent-importable.client.web.********************.js 3.08 kB 0 B

compressed-size-action

@github-actions GitHub Actions
Copy link

Deploy build 11861 of dotcom:rendering-all to CODE

All deployment options

From guardian/actions-riff-raff.

@cemms1 cemms1 marked this pull request as ready for review July 19, 2024 13:02
@cemms1 cemms1 requested a review from a team as a code owner July 19, 2024 13:02
@github-actions GitHub Actions
Copy link

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

@cemms1
Copy link
Contributor Author

cemms1 commented Jul 19, 2024

Not needed any more so closing

@cemms1 cemms1 closed this Jul 19, 2024
@cemms1 cemms1 deleted the revert-11929-cemms1/remove-hardcoded-contributionsServiceUrl branch July 19, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dotcom-rendering
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@cemms1