New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for supported by badging #1532
Conversation
Size Change: +358 B (0%) Total Size: 487 kB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing
This is basically spot on; just a few nudges around things that aren't wrong as such, just not in line with DCR best practices
PRbuilds results: 💚 AMP validation LightHouse Reporting --automated message |
Sorry that a) I’m late to this, b) I can’t answer my own question by looking at the code, but will it support different logo resolutions (scale them to the same size)? |
What does this change?
Adds the rendering of 'commercial' badges to Web. 'Commercial' happens to handle all the badging for articles, regardless of whether or not it's actually a commercial sponsorship.
Frontend
DCR
Why?
https://trello.com/c/znrv4cCk/1674-add-support-for-supported-by-badging