Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for supported by badging #1532

Merged
merged 5 commits into from Jun 3, 2020
Merged

Add support for supported by badging #1532

merged 5 commits into from Jun 3, 2020

Conversation

rcrphillips
Copy link
Contributor

What does this change?

Adds the rendering of 'commercial' badges to Web. 'Commercial' happens to handle all the badging for articles, regardless of whether or not it's actually a commercial sponsorship.

Frontend

Screen Shot 2020-06-02 at 14 01 25

Screen Shot 2020-06-02 at 14 02 18

DCR

Screen Shot 2020-06-02 at 14 01 56

Screen Shot 2020-06-02 at 14 02 27

Why?

https://trello.com/c/znrv4cCk/1674-add-support-for-supported-by-badging

@github-actions
Copy link

github-actions bot commented Jun 2, 2020

Size Change: +358 B (0%)

Total Size: 487 kB

Filename Size Change
dist/frontend.server.js 184 kB +358 B (0%)
ℹ️ View Unchanged
Filename Size Change
dist/consent-management-platform-utilities.js 575 B 0 B
dist/consent-management-platform-utilities.legacy.js 579 B 0 B
dist/ga.js 1.97 kB 0 B
dist/ga.legacy.js 2.46 kB 0 B
dist/lotame.js 1.08 kB 0 B
dist/lotame.legacy.js 1.08 kB 0 B
dist/MostViewedFooterData.js 5.63 kB 0 B
dist/MostViewedFooterData.legacy.js 5.9 kB 0 B
dist/MostViewedRightWrapper.js 6.25 kB 0 B
dist/MostViewedRightWrapper.legacy.js 6.55 kB 0 B
dist/OnwardsLower.js 10.7 kB 0 B
dist/OnwardsLower.legacy.js 10.9 kB 0 B
dist/OnwardsUpper.js 11.2 kB 0 B
dist/OnwardsUpper.legacy.js 11.5 kB 0 B
dist/ophan.js 5.28 kB 0 B
dist/ophan.legacy.js 5.27 kB 0 B
dist/react.js 69.6 kB 0 B
dist/react.legacy.js 71.5 kB 0 B
dist/sentry.js 18.7 kB 0 B
dist/sentry.legacy.js 18.7 kB 0 B
dist/vendors~ConsentManagementPlatform.js 11.4 kB 0 B
dist/vendors~ConsentManagementPlatform.legacy.js 11.4 kB 0 B
dist/vendors~ConsentManagementPlatform~consent-management-platform-utilities.js 7.41 kB 0 B
dist/vendors~ConsentManagementPlatform~consent-management-platform-utilities.legacy.js 7.42 kB 0 B

compressed-size-action

@rcrphillips
Copy link
Contributor Author

Copy link
Contributor

@oliverlloyd oliverlloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing

This is basically spot on; just a few nudges around things that aren't wrong as such, just not in line with DCR best practices

src/web/components/Branding.tsx Outdated Show resolved Hide resolved
src/web/components/Branding.tsx Outdated Show resolved Hide resolved
src/web/components/Branding.tsx Outdated Show resolved Hide resolved
src/web/components/Branding.tsx Outdated Show resolved Hide resolved
@PRBuilds
Copy link

PRBuilds commented Jun 3, 2020

PRbuilds results:

💚 AMP validation
amp-report.txt

LightHouse Reporting
1591182517.report.html

--automated message

@rcrphillips rcrphillips merged commit eebc1f4 into master Jun 3, 2020
@rcrphillips rcrphillips deleted the rp-add-branding branch June 3, 2020 11:50
@paperboyo
Copy link
Contributor

Sorry that a) I’m late to this, b) I can’t answer my own question by looking at the code, but will it support different logo resolutions (scale them to the same size)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants