Display As Const Enum

[JamieB-gu]

What does this change?

Migrates the Display type from a string to a const enum. First part of the work towards migrating DCR to using the types repo. Enabled by #1533.

Before

Display was this type:

type Display = 'standard' | 'immersive' | 'showcase';

After

Display is this type:

declare const enum Display {
    Standard,
    Immersive,
    Showcase,
}

Why?

Will enable DCR and AR to consolidate on the same Format type for articles, which should allow us to share a lot more code. Hopefully will also reduce the bundle size eventually, since in theory const enums produce code that is smaller than strings.

FYI @alexduf @webb04 @frankie297

[github-actions]

Size Change: +49 B (0%)

Total Size: 544 kB

Filename	Size	Change
dist/frontend.server.js	204 kB	+49 B (0%)

ℹ️ View Unchanged

Filename	Size	Change
dist/dynamicImport.js	1.89 kB	0 B
dist/dynamicImport.legacy.js	1.94 kB	0 B
dist/ga.js	1.95 kB	0 B
dist/ga.legacy.js	2.44 kB	0 B
dist/GetMatchStats.js	3.44 kB	0 B
dist/GetMatchStats.legacy.js	3.52 kB	0 B
dist/lotame.js	1.08 kB	0 B
dist/lotame.legacy.js	1.07 kB	0 B
dist/MostViewedFooterData.js	5.63 kB	0 B
dist/MostViewedFooterData.legacy.js	5.84 kB	0 B
dist/MostViewedRightWrapper.js	6.25 kB	0 B
dist/MostViewedRightWrapper.legacy.js	6.48 kB	0 B
dist/OnwardsLower.js	10.6 kB	0 B
dist/OnwardsLower.legacy.js	10.9 kB	0 B
dist/OnwardsUpper.js	11.2 kB	0 B
dist/OnwardsUpper.legacy.js	11.4 kB	0 B
dist/ophan.js	5.45 kB	0 B
dist/ophan.legacy.js	5.43 kB	0 B
dist/react.js	98.9 kB	0 B
dist/react.legacy.js	101 kB	0 B
dist/sentry.js	18.7 kB	0 B
dist/sentry.legacy.js	18.3 kB	0 B
dist/shimport.js	3.19 kB	0 B
dist/shimport.legacy.js	3.2 kB	0 B

_{compressed-size-action}

[gtrufitt]

I'm in 👍

[oliverlloyd]

Let's do this