Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up pre-push hook #1653

Merged
merged 4 commits into from Jun 24, 2020
Merged

Speed up pre-push hook #1653

merged 4 commits into from Jun 24, 2020

Conversation

gtrufitt
Copy link
Contributor

@gtrufitt gtrufitt commented Jun 24, 2020

What does this change?

  • Jest only runs on changed files
  • Eslint only runs on staged files
  • We don't check bundling

TSC still runs on everything, maybe opportunities there.

Before and after is with no changes to files so it will be slower, but still much quicker.

Before

image

After

image

Update After

Ok, so added parallelisation with https://github.com/mysticatea/npm-run-all/blob/HEAD/docs/run-p.md

image

Why?

Pre push is valuable, but 2 minutes is a long time.

@gtrufitt
Copy link
Contributor Author

gtrufitt commented Jun 24, 2020

I consider this @oliverlloyd's going away present

@github-actions
Copy link

github-actions bot commented Jun 24, 2020

Size Change: 0 B

Total Size: 544 kB

ℹ️ View Unchanged
Filename Size Change
dist/dynamicImport.js 1.89 kB 0 B
dist/dynamicImport.legacy.js 1.94 kB 0 B
dist/frontend.server.js 204 kB 0 B
dist/ga.js 1.95 kB 0 B
dist/ga.legacy.js 2.44 kB 0 B
dist/GetMatchStats.js 3.44 kB 0 B
dist/GetMatchStats.legacy.js 3.52 kB 0 B
dist/lotame.js 1.08 kB 0 B
dist/lotame.legacy.js 1.07 kB 0 B
dist/MostViewedFooterData.js 5.63 kB 0 B
dist/MostViewedFooterData.legacy.js 5.84 kB 0 B
dist/MostViewedRightWrapper.js 6.25 kB 0 B
dist/MostViewedRightWrapper.legacy.js 6.48 kB 0 B
dist/OnwardsLower.js 10.6 kB 0 B
dist/OnwardsLower.legacy.js 10.9 kB 0 B
dist/OnwardsUpper.js 11.2 kB 0 B
dist/OnwardsUpper.legacy.js 11.4 kB 0 B
dist/ophan.js 5.45 kB 0 B
dist/ophan.legacy.js 5.43 kB 0 B
dist/react.js 98.9 kB 0 B
dist/react.legacy.js 101 kB 0 B
dist/sentry.js 18.7 kB 0 B
dist/sentry.legacy.js 18.3 kB 0 B
dist/shimport.js 3.19 kB 0 B
dist/shimport.legacy.js 3.2 kB 0 B

compressed-size-action

Copy link
Contributor

@oliverlloyd oliverlloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I consider this @oliverlloyd's going away present

Now. You do this now? Where were you 3 months ago?

Love it though

@gtrufitt
Copy link
Contributor Author

Merging now, will tidy up terminal later

@gtrufitt gtrufitt merged commit 5b7297f into master Jun 24, 2020
@gtrufitt gtrufitt deleted the gtrufitt/jest-speed branch June 24, 2020 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants