Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete tracking #3592

Merged
merged 2 commits into from
Nov 4, 2021
Merged

Remove obsolete tracking #3592

merged 2 commits into from
Nov 4, 2021

Conversation

simonbyford
Copy link
Contributor

What does this change?

Removes obsolete tracking code from web and AMP articles. This is a continuation of guardian/frontend#24326.

Why?

These requests are failing on every page load and cluttering the console.

Before

When visiting a web article:

Screenshot 2021-11-04 at 11 08 32

When visiting an AMP article:

Screenshot 2021-11-04 at 11 08 54

After

The errors are gone 馃獎

Copy link
Member

@arelra arelra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤

@github-actions
Copy link

github-actions bot commented Nov 4, 2021

Size Change: -176 B (0%)

Total Size: 3.1 MB

Filename Size Change
dotcom-rendering/dist/frontend.server.js 2.47 MB -60 B (0%)
dotcom-rendering/dist/ga.js 3.81 kB -54 B (-1%)
dotcom-rendering/dist/ga.legacy.js 4.04 kB -53 B (-1%)
dotcom-rendering/dist/react.js 137 kB -9 B (0%)
鈩癸笍 View Unchanged
Filename Size
dotcom-rendering/dist/101.js 21.1 kB
dotcom-rendering/dist/101.legacy.js 21.1 kB
dotcom-rendering/dist/943.js 3.57 kB
dotcom-rendering/dist/943.legacy.js 3.69 kB
dotcom-rendering/dist/atomIframe.js 1.87 kB
dotcom-rendering/dist/atomIframe.legacy.js 2.13 kB
dotcom-rendering/dist/braze-web-sdk-core.js 36.1 kB
dotcom-rendering/dist/braze-web-sdk-core.legacy.js 36.1 kB
dotcom-rendering/dist/coreVitals.js 4.03 kB
dotcom-rendering/dist/coreVitals.legacy.js 4.31 kB
dotcom-rendering/dist/dynamicImport.js 2.99 kB
dotcom-rendering/dist/dynamicImport.legacy.js 3.27 kB
dotcom-rendering/dist/EditionDropdown.js 693 B
dotcom-rendering/dist/EditionDropdown.legacy.js 701 B
dotcom-rendering/dist/elements-CalloutBlockComponent.js 5.91 kB
dotcom-rendering/dist/elements-CalloutBlockComponent.legacy.js 6.25 kB
dotcom-rendering/dist/elements-DocumentBlockComponent.js 571 B
dotcom-rendering/dist/elements-DocumentBlockComponent.legacy.js 602 B
dotcom-rendering/dist/elements-InstagramBlockComponent.js 434 B
dotcom-rendering/dist/elements-InstagramBlockComponent.legacy.js 452 B
dotcom-rendering/dist/elements-InteractiveBlockComponent.js 2.71 kB
dotcom-rendering/dist/elements-InteractiveBlockComponent.legacy.js 2.84 kB
dotcom-rendering/dist/elements-InteractiveContentsBlockElement.js 1.87 kB
dotcom-rendering/dist/elements-InteractiveContentsBlockElement.legacy.js 1.95 kB
dotcom-rendering/dist/elements-MapEmbedBlockComponent.js 1.62 kB
dotcom-rendering/dist/elements-MapEmbedBlockComponent.legacy.js 1.68 kB
dotcom-rendering/dist/elements-RichLinkComponent.js 3.27 kB
dotcom-rendering/dist/elements-RichLinkComponent.legacy.js 3.31 kB
dotcom-rendering/dist/elements-SpotifyBlockComponent.js 1.55 kB
dotcom-rendering/dist/elements-SpotifyBlockComponent.legacy.js 1.6 kB
dotcom-rendering/dist/elements-VideoFacebookBlockComponent.js 1.63 kB
dotcom-rendering/dist/elements-VideoFacebookBlockComponent.legacy.js 1.68 kB
dotcom-rendering/dist/elements-VineBlockComponent.js 579 B
dotcom-rendering/dist/elements-VineBlockComponent.legacy.js 594 B
dotcom-rendering/dist/elements-YoutubeBlockComponent.js 2.17 kB
dotcom-rendering/dist/elements-YoutubeBlockComponent.legacy.js 2.25 kB
dotcom-rendering/dist/embedIframe.js 1.88 kB
dotcom-rendering/dist/embedIframe.legacy.js 2.13 kB
dotcom-rendering/dist/GetMatchStats.js 3.28 kB
dotcom-rendering/dist/GetMatchStats.legacy.js 3.34 kB
dotcom-rendering/dist/guardian-braze-components-banner.js 9.81 kB
dotcom-rendering/dist/guardian-braze-components-banner.legacy.js 9.82 kB
dotcom-rendering/dist/guardian-braze-components-end-of-article.js 6.51 kB
dotcom-rendering/dist/guardian-braze-components-end-of-article.legacy.js 6.52 kB
dotcom-rendering/dist/MostViewedFooterData.js 6.32 kB
dotcom-rendering/dist/MostViewedFooterData.legacy.js 6.41 kB
dotcom-rendering/dist/MostViewedRightWrapper.js 5.61 kB
dotcom-rendering/dist/MostViewedRightWrapper.legacy.js 5.88 kB
dotcom-rendering/dist/newsletterEmbedIframe.js 1.83 kB
dotcom-rendering/dist/newsletterEmbedIframe.legacy.js 2.08 kB
dotcom-rendering/dist/OnwardsLower.js 11.3 kB
dotcom-rendering/dist/OnwardsLower.legacy.js 11.6 kB
dotcom-rendering/dist/OnwardsUpper.js 12.4 kB
dotcom-rendering/dist/OnwardsUpper.legacy.js 12.7 kB
dotcom-rendering/dist/ophan.js 7.17 kB
dotcom-rendering/dist/ophan.legacy.js 7.36 kB
dotcom-rendering/dist/react.legacy.js 143 kB
dotcom-rendering/dist/sentry.js 677 B
dotcom-rendering/dist/sentry.legacy.js 687 B
dotcom-rendering/dist/sentryLoader.js 4.72 kB
dotcom-rendering/dist/sentryLoader.legacy.js 7.67 kB
dotcom-rendering/dist/shimport.js 2.75 kB
dotcom-rendering/dist/shimport.legacy.js 2.76 kB
dotcom-rendering/dist/SignInGateMain.js 1.84 kB
dotcom-rendering/dist/SignInGateMain.legacy.js 1.88 kB

compressed-size-action

@simonbyford simonbyford merged commit ae669fb into main Nov 4, 2021
@simonbyford simonbyford deleted the remove-obsolete-tracking branch November 4, 2021 12:45
chrislomaxjones pushed a commit that referenced this pull request Nov 8, 2021
This was removed in error in this PR: #3592
@mxdvl mxdvl mentioned this pull request Dec 9, 2021
@mxdvl mxdvl linked an issue Dec 9, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dim the beacon
2 participants