Explicitly exit deno once Lighthouse script has finished #5159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshCorr
requested review from
a team,
JamieB-gu,
marsavar and
iainjchambers-guardian
as code owners
|
Size Change: 0 B Total Size: 1.72 MB ℹ️ View Unchanged
|
⚡️ Lighthouse report for the changes in this PRLighthouse tested 2 URLs Report for Article
Report for Front
|
|
Potentially related octokit/octokit.js#2079 |
AshCorr
changed the title
ioannakok
approved these changes
Jun 8, 2022
bryophyta
reviewed
Jun 8, 2022
bryophyta
approved these changes
Jun 8, 2022
OllysCoding
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds a
Deno.exit(0)after action has completed.Why?
I'm not a deno expert, but I'm assuming that deno isn't exiting because its waiting for a promise to be fullfilled somewhere? This issue in octokit sounds potentially related and might be the root issue octokit/octokit.js#2079 , although I'm not quite sure why it started now.
This PR makes deno explicitly exit with a success code once all tasks have been completed.