Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitter embeds #741

Merged
merged 9 commits into from Sep 12, 2019
Merged

Twitter embeds #741

merged 9 commits into from Sep 12, 2019

Conversation

rcrphillips
Copy link
Contributor

@rcrphillips rcrphillips commented Aug 30, 2019

What does this change?

Adds the ability to render embedded tweets in articles.
Screen Shot 2019-08-30 at 12 24 48

And the nojs fallback version:
Screen Shot 2019-09-11 at 21 20 30

Why?

Because they're popular embeds....

Link to supporting Trello card

https://trello.com/c/NduOSPaC

@rcrphillips rcrphillips changed the title Twitter embeds WIP -Twitter embeds Aug 30, 2019
@PRBuilds
Copy link

PRbuilds results:

💚 AMP validation
amp-report.txt

LightHouse Reporting

--automated message

@rcrphillips rcrphillips changed the title WIP -Twitter embeds Twitter embeds Sep 11, 2019
Copy link
Contributor

@gtrufitt gtrufitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs some bottom margin on the element but other than that 👍

@rcrphillips rcrphillips merged commit 2896703 into master Sep 12, 2019
@rcrphillips rcrphillips deleted the rp-twitter-embed branch September 12, 2019 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants