Ensure node versions are aligned (bis) #7998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxdvl
force-pushed
the
mxdvl/node-versions
branch
3 times, most recently
from
9801181
to
e0cddd6
Compare
|
Size Change: 0 B Total Size: 571 kB ℹ️ View Unchanged
|
JamieB-gu
previously approved these changes
Jun 23, 2023
Add a check for node versions in all known config using it: - dotcom-rendering’s riff-raff.yaml - dotcom-rendering’s Containerfile - apps-rendering’s riff-raff.yaml Co-authored-by: Alex Sanders <alex@sndrs.dev>
mxdvl
force-pushed
the
mxdvl/node-versions
branch
from
e0cddd6
to
e2f9c43
Compare
JamieB-gu
approved these changes
Jun 23, 2023
|
Just added Node 18.16.1 AMIGo recipes for |
Merged
|
Working as intended: https://github.com/guardian/dotcom-rendering/actions/runs/5621099965/job/15231278328 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Add a check for Node versions in all known config using it:
dotcom-rendering/scripts/deploy/riff-raff.yamldotcom-rendering/Containerfileapps-rendering/riff-raff.yamlThe
lint-projecttarget is run as part ofmake validateand in CIAMIGo recipes have been updated to contain the exact node version: major.minor.patch.
Why?
Alternative to #7959 – We are using a regular expression rather than a
SemVerclass and full parsing in order to reduce our dependencies.Ensures that robots warn us when we do the next #7948
Screenshots