Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No mocked Config context provider #8896

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Conversation

mxdvl
Copy link
Member

@mxdvl mxdvl commented Sep 22, 2023

What does this change?

Remove the global mock for Config provider added in #8704.

Easier to see without the whitespace change.

Why?

Explicit is less suprising than implicit, which aligns with our recommendations.

Makes the changes in #8535 easier

explicit is better than implicit
@mxdvl mxdvl added the Health label Sep 22, 2023
@mxdvl mxdvl requested a review from a team as a code owner September 22, 2023 15:03
@mxdvl mxdvl added the run_chromatic Runs chromatic when label is applied label Sep 22, 2023
Copy link
Contributor

@cemms1 cemms1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice one! There's not as many components that need to be wrapped in the context provider as I originally thought, so this is much neater and easier to see what's going on.

Apologies for making it a bit difficult on the other PR!

@github-actions
Copy link

Size Change: 0 B 🆕

Total Size: 0 B

compressed-size-action

@mxdvl mxdvl merged commit be94d63 into main Sep 22, 2023
32 checks passed
@mxdvl mxdvl deleted the mxdvl/config-context-no-magic branch September 22, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dotcom-rendering run_chromatic Runs chromatic when label is applied
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants