Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adaptive site: disable non-critical tasks for users in the adaptive-site test #9024

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Adaptive site: disable non-critical tasks for users in the adaptive-site test #9024

merged 1 commit into from
Oct 9, 2023

Conversation

sndrs
Copy link
Member

@sndrs sndrs commented Oct 4, 2023 •
edited
Loading

depends on #9021(0💄)...

What does this change?

  • only runs critical tasks for:
    • users in the adaptive-site test variant who experience poor page performance, or who are on unsupported browsers1
    • anyone that adds an #adapt hash to the URL

Why?

it's part of @guardian/open-journalism's adaptive-site test to make the Guardian more open to users with slow devices or connectivity

Footnotes

  1. browsers that do not support the performance api will automatically be treated as as candidates for adaptation. ↩

@sndrs sndrs changed the title Adaptive site: disable non-critical tasks for users in the adaptive site test Adaptive site: disable non-critical tasks for users in the adaptive-site test Oct 4, 2023
@github-actions
Copy link

github-actions bot commented Oct 4, 2023 •
edited
Loading

Size Change: 0 B 🆕

Total Size: 0 B

compressed-size-action

Base automatically changed from oj/adaptive/prioritised-hydration to main October 6, 2023 09:56
@sndrs sndrs marked this pull request as ready for review October 6, 2023 11:14
@sndrs sndrs requested a review from a team as a code owner October 6, 2023 11:14
@sndrs sndrs added the run_chromatic Runs chromatic when label is applied label Oct 6, 2023
mxdvl
mxdvl approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@mxdvl mxdvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍊

Really hoping “Adaptive site” gains the same momentum as “Responsive site” 🤞

@sndrs @mxdvl
feat: adapt the site (for users in the test)
08ac220 
disables non-critical tasks for poorly performing
pages for the adaptive-site test variant.

Co-authored-by: Max Duval <max.duval@theguardian.com>
@sndrs sndrs merged commit b865fc1 into main Oct 9, 2023
26 checks passed
@sndrs sndrs deleted the oj/adaptive/adapt! branch October 9, 2023 10:57
@sndrs sndrs mentioned this pull request Apr 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxdvl mxdvl mxdvl approved these changes

Assignees
No one assigned
Labels
dotcom-rendering run_chromatic Runs chromatic when label is applied 📶 Open Journalism
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sndrs @mxdvl