Add update dyanmo functionality #4
Conversation
| case class Switch(name: String, default: Boolean = false) { | ||
| @volatile private var state: Boolean = default | ||
|
|
||
| def enabled: Boolean = state | ||
|
|
||
| def enabled_=(value: Boolean) = state = value | ||
|
|
||
| def toStringAttribute() = { | ||
| new AttributeValue().withS(this.name) |
There was a problem hiding this comment.
Can you not store boolean in DynamoDB?
There was a problem hiding this comment.
This is just how the library / switchboard was originally written! Maybe you didn't used to be able to store booleans.. Not sure.
| def updateDynamo(switches : List[Switch]) = { | ||
| val listWR = switches.map(switch => { | ||
| new WriteRequest(new PutRequest(Map("name" -> switch.toStringAttribute(), "enabled" -> switch.toNumAttributeValue()).asJava)) | ||
| }).asJava |
| val results = dynamoDbClient.scan(new ScanRequest(dynamoDbTableName)).getItems.asScala.toList.map(_.asScala.toMap) | ||
| results.map(item => { | ||
| Switch(item("name").getS, item("enabled").getN == "1") | ||
| }) |
There was a problem hiding this comment.
No need for the inside {}
You also don't need the intermediary val results and the double map. What about:
dynamoDbClient
.scan(new ScanRequest(dynamoDbTableName))
.getItems.asScala.toList
.map {
val item = _.asScala.toMap
Switch(item("name").getS, item("enabled").getN == "1")
}
| new AttributeValue().withS(this.name) | ||
| } | ||
|
|
||
| def toNumAttributeValue() = { |
There was a problem hiding this comment.
This seems like an odd method. It converts the default value to a string containing 1 or 0.
Perhaps a better name might be defaultAsAttributeValue?
But even better might be to inline this logic, or if used more than once define a more generic and pure method in a companion or helper object. E.g.
def asAttributeValue(b: Boolean) = {
val str = if(b) "1" else "0"
new AttributeValue().withN(str)
}
A minor tweak as well, but if a method has no side effects it is idiomatic in Scala to declare it without the () to indicate this. E.g. toNumAttributeValue = {...}
| dynamoDbClient.batchWriteItem(Map(dynamoDbTableName -> listWR).asJava) | ||
| } catch { | ||
| case e: Exception => println(e) | ||
| case _ => println("Something went wrong") |
There was a problem hiding this comment.
Ideally we'd log this, but I can see adding support for a logger might be easier in a separate PR.
There was a problem hiding this comment.
Yep changed to error and warn for now?
Calum-Campbell
force-pushed
the
cc-add-update-functionality
branch
2 times, most recently
from
ebad0ae
to
96c7ae7
Compare
Calum-Campbell
force-pushed
the
cc-add-update-functionality
branch
from
96c7ae7
to
8db5fe5
Compare
Used in :