Google auth 240 #136
Merged
Google auth 240 #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonytw1
force-pushed
the
google-auth-240
branch
from
94e83b3
to
90ee484
Compare
fredex42
approved these changes
Dec 11, 2023
| GoogleAuthConfig( | ||
| clientId, | ||
| clientSecret, | ||
| redirectUrl, | ||
| domain, | ||
| domains = List("guardian.co.uk"), | ||
| maxAuthAge = Some(java.time.Duration.ofDays(90)), |
There was a problem hiding this comment.
Seems like quite a long time?
There was a problem hiding this comment.
Yeah... bonono is set to the same value.
Happy to find a better example in another tool and then adjust these in 2 new PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Update to latest google auth library and drop unused overrides.
Likely enforces 2FA.
We should be trying to drop as many overrides as we can as the frameworks we depend on catch up with better dependencies of their own.
How to test
How can we measure success?
Have we considered potential risks?
Images
Accessibility