Skip to content

Commit

Permalink
Merge pull request #25712 from guardian/vb/delete-mandatory-gate-test
Browse files Browse the repository at this point in the history
Delete code for the Sign in Gate Mandatory test.
  • Loading branch information
vlbee committed Nov 24, 2022
2 parents 1307770 + e436334 commit 044ba4e
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 227 deletions.
80 changes: 0 additions & 80 deletions common/app/conf/switches/ABTestSwitches.scala
Original file line number Diff line number Diff line change
Expand Up @@ -25,86 +25,6 @@ trait ABTestSwitches {
exposeClientSide = true,
)

Switch(
ABTests,
"ab-sign-in-gate-mandatory-long-test-control-uk",
"Long mandatory sign in gate trial",
owners = Seq(Owner.withGithub("vlbee")),
safeState = Off,
sellByDate = Some(LocalDate.of(2023, 1, 31)),
exposeClientSide = true,
)

Switch(
ABTests,
"ab-sign-in-gate-mandatory-long-test-control-na",
"Long mandatory sign in gate trial",
owners = Seq(Owner.withGithub("vlbee")),
safeState = Off,
sellByDate = Some(LocalDate.of(2023, 1, 31)),
exposeClientSide = true,
)

Switch(
ABTests,
"ab-sign-in-gate-mandatory-long-test-control-aunz",
"Long mandatory sign in gate trial",
owners = Seq(Owner.withGithub("vlbee")),
safeState = Off,
sellByDate = Some(LocalDate.of(2023, 1, 31)),
exposeClientSide = true,
)

Switch(
ABTests,
"ab-sign-in-gate-mandatory-long-test-control-eu",
"Long mandatory sign in gate trial",
owners = Seq(Owner.withGithub("vlbee")),
safeState = Off,
sellByDate = Some(LocalDate.of(2023, 1, 31)),
exposeClientSide = true,
)

Switch(
ABTests,
"ab-sign-in-gate-mandatory-long-test-variant-uk",
"Long mandatory sign in gate trial",
owners = Seq(Owner.withGithub("vlbee")),
safeState = Off,
sellByDate = Some(LocalDate.of(2023, 1, 31)),
exposeClientSide = true,
)

Switch(
ABTests,
"ab-sign-in-gate-mandatory-long-test-variant-na",
"Long mandatory sign in gate trial",
owners = Seq(Owner.withGithub("vlbee")),
safeState = Off,
sellByDate = Some(LocalDate.of(2023, 1, 31)),
exposeClientSide = true,
)

Switch(
ABTests,
"ab-sign-in-gate-mandatory-long-test-variant-aunz",
"Long mandatory sign in gate trial",
owners = Seq(Owner.withGithub("vlbee")),
safeState = Off,
sellByDate = Some(LocalDate.of(2023, 1, 31)),
exposeClientSide = true,
)

Switch(
ABTests,
"ab-sign-in-gate-mandatory-long-test-variant-eu",
"Long mandatory sign in gate trial",
owners = Seq(Owner.withGithub("vlbee")),
safeState = Off,
sellByDate = Some(LocalDate.of(2023, 1, 31)),
exposeClientSide = true,
)

Switch(
ABTests,
"ab-deeply-read-article-footer",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,6 @@ import { remoteRRHeaderLinksTest } from './tests/remote-header-test';
import { removePrebidA9Canada } from './tests/removePrebidA9Canada';
import { signInGateMainControl } from './tests/sign-in-gate-main-control';
import { signInGateMainVariant } from './tests/sign-in-gate-main-variant';
import {
signInGateMandatoryLongTestControlAunz,
signInGateMandatoryLongTestControlEu,
signInGateMandatoryLongTestControlNa,
signInGateMandatoryLongTestControlUk,
signInGateMandatoryLongTestVariantAunz,
signInGateMandatoryLongTestVariantEu,
signInGateMandatoryLongTestVariantNa,
signInGateMandatoryLongTestVariantUk,
} from './tests/sign-in-gate-mandatory-long';

// keep in sync with ab-tests in dotcom-rendering
// https://github.com/guardian/dotcom-rendering/blob/main/dotcom-rendering/src/web/experiments/ab-tests.ts
Expand All @@ -26,13 +16,5 @@ export const concurrentTests: readonly ABTest[] = [
deeplyReadArticleFooterTest,
consentlessAds,
integrateIma,
signInGateMandatoryLongTestControlAunz,
signInGateMandatoryLongTestControlEu,
signInGateMandatoryLongTestControlNa,
signInGateMandatoryLongTestControlUk,
signInGateMandatoryLongTestVariantAunz,
signInGateMandatoryLongTestVariantNa,
signInGateMandatoryLongTestVariantEu,
signInGateMandatoryLongTestVariantUk,
removePrebidA9Canada,
];
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ export const signInGateMainVariant = {
author: 'Mahesh Makani',
description:
'Show sign in gate to 100% of users on 3rd article view of simple article templates, with higher priority over banners and epic. Main/Variant Audience.',
audience: 0.7119,
audienceOffset: 0.1254,
audience: 0.9,
audienceOffset: 0.0,
successMeasure: 'Users sign in or create a Guardian account',
audienceCriteria:
'3rd article of the day, lower priority than consent banner, simple articles (not gallery, live etc.), not signed in, not shown after dismiss, not on help, info sections etc. Exclude iOS 9 and guardian-live-australia. Suppresses other banners, and appears over epics',
Expand Down

This file was deleted.

0 comments on commit 044ba4e

Please sign in to comment.