Skip to content

Commit

Permalink
Merge pull request #20660 from guardian/revert-20619-rp-interactive-h…
Browse files Browse the repository at this point in the history
…eader

Revert "Midterms interactives header switch "
  • Loading branch information
Rob Phillips committed Nov 8, 2018
2 parents a8eac65 + fff9533 commit 95d437d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 13 deletions.
12 changes: 1 addition & 11 deletions common/app/conf/switches/FeatureSwitches.scala
Original file line number Diff line number Diff line change
Expand Up @@ -495,17 +495,6 @@ trait FeatureSwitches {
exposeClientSide = true
)

// Midterms interactive header switch
val InteractiveHeaderSwitch = Switch(
SwitchGroup.Feature,
"interactive-header-switch",
"If switched on, the header on all interctives will display in full.",
owners = Seq(Owner.withName("dotcom.platform")),
safeState = Off,
sellByDate = new LocalDate(2018, 11, 9),
exposeClientSide = true
)

val NewNavEnabled = Switch(
SwitchGroup.Feature,
"new-nav-enabled",
Expand All @@ -515,4 +504,5 @@ trait FeatureSwitches {
sellByDate = new LocalDate(2018, 11, 19),
exposeClientSide = false
)

}
4 changes: 2 additions & 2 deletions common/app/model/content.scala
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ import views.support._
import scala.collection.JavaConverters._
import scala.util.Try
import implicits.Booleans._
import conf.switches.Switches.InteractiveHeaderSwitch

sealed trait ContentType {
def content: Content
Expand Down Expand Up @@ -885,11 +884,12 @@ object Interactive {
val contentType = DotcomContentType.Interactive
val fields = content.fields
val section = content.metadata.sectionId

val metadata = content.metadata.copy(
contentType = Some(contentType),
adUnitSuffix = section + "/" + contentType.name.toLowerCase,
twitterPropertiesOverrides = Map( "twitter:title" -> fields.linkText ),
contentWithSlimHeader = InteractiveHeaderSwitch.isSwitchedOff
contentWithSlimHeader = true
)
val contentOverrides = content.copy(
metadata = metadata
Expand Down

0 comments on commit 95d437d

Please sign in to comment.