Merge pull request #12772 from guardian/video-playlist-tracking

add tracking component name to video playlist
guardian · May 3, 2016 · d2e8d9e · d2e8d9e
2 parents cc53a57 + e9ed11d
commit d2e8d9e
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/common/app/fronts/FrontsApi.scala b/common/app/fronts/FrontsApi.scala
@@ -13,7 +13,7 @@ object FrontsApi extends ExecutionContexts {
     ApiClient(Configuration.aws.bucket, Configuration.facia.stage.toUpperCase, AmazonSdkS3Client(client))
   }
 
-  val crossAccountClient: ApiClient = {
+  lazy val crossAccountClient: ApiClient = {
     val client = new AmazonS3Client(Configuration.faciatool.crossAccountMandatoryCredentials)
     client.setEndpoint(AwsEndpoints.s3)
     ApiClient(Configuration.faciatool.crossAccountSourceBucket, Configuration.facia.stage.toUpperCase, AmazonSdkS3Client(client))

diff --git a/common/app/views/fragments/containers/facia_cards/videoContainer.scala.html b/common/app/views/fragments/containers/facia_cards/videoContainer.scala.html
@@ -12,7 +12,8 @@ <h2 class="video-title fc-container__header__title">
 </div>
 
 <div class="video-playlist video-playlist--start js-video-playlist"
-     data-number-of-videos="@(containerDefinition.collectionEssentials.items.zipWithIndex.length - 1)">
+     data-number-of-videos="@(containerDefinition.collectionEssentials.items.zipWithIndex.length - 1)"
+     data-component="video-playlist">
     <div class="video-playlist__control video-playlist__control--prev js-video-playlist-prev" data-link-name="video-container-prev">
         @fragments.inlineSvg("chevron-left", "icon", Seq("video-playlist__icon"))
     </div>
@@ -53,7 +54,7 @@ <h2 class="video-title fc-container__header__title">
                                 </div>
                             </div>
                             <div class="fc-item__video-fallback media__placeholder--active js-video-placeholder gu-media__fallback">
-                                <div class="@RenderClasses("fc-item__video-play", "media__placeholder--hidden", "vjs-big-play-button", "js-video-play-button")"><span class="vjs-control-text"></span></div>
+                                <div data-link-name="video-play-button-overlay" class="@RenderClasses("fc-item__video-play", "media__placeholder--hidden", "vjs-big-play-button", "js-video-play-button")"><span class="vjs-control-text"></span></div>
                                 <div class="fc-item__media-wrapper">
                                     <div class="fc-item__image-container u-responsive-ratio inlined-image">
                                     @InlineImage.fromFaciaContent(item).map { fallbackImage =>

diff --git a/common/app/views/fragments/items/facia_cards/contentCard.scala.html b/common/app/views/fragments/items/facia_cards/contentCard.scala.html
@@ -63,7 +63,7 @@
                     </div>
                 @fallback.map { fallbackImage =>
                     <div class="fc-item__video-fallback media__placeholder--active js-video-placeholder gu-media__fallback">
-                        <div class="@RenderClasses("fc-item__video-play", "media__placeholder--hidden", "vjs-big-play-button", "js-video-play-button")"><span class="vjs-control-text"></span></div>
+                        <div data-link-name="video-play-button-overlay" class="@RenderClasses("fc-item__video-play", "media__placeholder--hidden", "vjs-big-play-button", "js-video-play-button")"><span class="vjs-control-text"></span></div>
                         @itemImage(
                             fallbackImage.imageMedia,
                             inlineImage = containerIndex == 0 && index < 4,