Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make in-page interactions respond to touchstart event #80

Closed
ahume opened this issue Sep 14, 2012 · 2 comments
Closed

Make in-page interactions respond to touchstart event #80

ahume opened this issue Sep 14, 2012 · 2 comments

Comments

@ahume
Copy link
Contributor

ahume commented Sep 14, 2012

Binding only to click results in a 300ms delay before executing handler. Bind to touchstart as well and see the massive difference in responsiveness:

Theory here: https://developers.google.com/mobile/articles/fast_buttons

I'm thinking specifically on the sections dropdown control.
@mattandrews
Copy link
Contributor

Good call - will implement this today.

@ghost ghost assigned phamann Sep 14, 2012
@phamann
Copy link
Contributor

phamann commented Sep 14, 2012

Have now implemented this and is in master, it's also is much snappier :)

@phamann phamann closed this as completed Sep 14, 2012
nicl added a commit that referenced this issue Jan 31, 2018
@nicl
Log asynchronously
518bc76 
*Note: this will cause some log messages to be lost when the system is
 under very heavy load. This is considered a worthwhile tradeoff if
 it ensures the system stay active and serving some requests.*

It is bad practice to do synchronous logging within Akka. Moreover,
thread dumps from a recent period of heavy load and poor performance
appear to indicate contention caused by blocking within the main akka
thread pool. All of the default dispatcher threads bar one looked
like:

```"application-akka.actor.default-dispatcher-11" #80 prio=5 os_prio=0 tid=0x00007fa448007000 nid=0x6e4 waiting for monitor entry [0x00007fa464418000]
   java.lang.Thread.State: BLOCKED (on object monitor)
        at ch.qos.logback.core.AppenderBase.doAppend(AppenderBase.java:63)
        - waiting to lock <0x000000064f717780> (a com.gu.logback.appender.kinesis.KinesisAppender)```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ahume @phamann @mattandrews