New Nav updates #15605
Merged
New Nav updates #15605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NataliaLKB
force-pushed
the
nb-nav-changes
branch
from
91c5b66
to
997c42c
Compare
sndrs
reviewed
Jan 18, 2017
|
|
||
| &:hover, | ||
| &:focus { | ||
| text-decoration: none; | ||
| color: #ffffff; | ||
| } | ||
|
|
||
| .tertiary-navigation__item--current-section & { | ||
| &--current-section { |
There was a problem hiding this comment.
this would make this selector tricky to grep
gtrufitt
approved these changes
Jan 19, 2017
| NavLink("Jason Wilson", "/profile/wilson-jason"), | ||
| NavLink("Brigid Delaney", "/profile/brigiddelaney"), | ||
| columnists | ||
| val au = NavLinkLists( |
There was a problem hiding this comment.
Is there a reason this was compressed to single line over multi line? Easier to read/remove/add if it's multi I think?
There was a problem hiding this comment.
Just consistency, but looking at it again this morning I agree with you! I will change all the opinion to be multi line again.
Thanks :)
|
Seen on PROD (merged by @NataliaLKB 26 minutes and 10 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR prepares the new nav test to go out to everyone. Other than some refactoring, The biggest difference is that there are only going to be 4-6 items shown on the subsection nav. This is ordered by popularity and so I have split all the lists into most popular, and least popular.
I would recommend reviewing commit by commit 馃槃
The nav is also on every page, not just fronts.
@zeftilldeath is updating the styling slightly in a separate PR.
cc @stephanfowler
This is the subsection nav:
What is the value of this and can you measure success?
This test will go out to everyone as it was successful. We will continue to iterate and test each of the changes to make sure we are providing the best user experience to the most number of users.
Does this affect other platforms - Amp, Apps, etc?
Nope
Tested in CODE?
No, but I tested a lot locally so I shouldn't need to.