Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@ not $ to access variable #15649

Merged
merged 1 commit into from Jan 21, 2017
Merged

@ not $ to access variable #15649

merged 1 commit into from Jan 21, 2017

Conversation

philwills
Copy link
Contributor

What does this change?

Fixes broken membership link

@PRBuilds
Copy link

PR build results:
screenshots > mobile.png • wide.png • tablet.png • desktop.png
other > thrown-exceptions.js • performanceComparisonSummary.txt

-automated message

paulbrown1982
paulbrown1982 reviewed Jan 21, 2017
View reviewed changes
Copy link
Member

@paulbrown1982 paulbrown1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to change the ${ to @{ in the INTCMP value too.

@philwills
Copy link
Contributor Author

Thanks @paulbrown1982

@philwills philwills merged commit ac572bb into master Jan 21, 2017
@philwills philwills deleted the twirl-edition branch January 21, 2017 20:18
@prout-bot
Copy link
Collaborator

Seen on PROD (merged by @philwills 14 minutes and 50 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbrown1982 paulbrown1982 paulbrown1982 left review comments

Assignees
No one assigned
Labels
Seen-on-PROD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@philwills @PRBuilds @prout-bot @paulbrown1982