Video main media caption #15952
Video main media caption #15952
Conversation
|
PR build results: screenshots exceptions (0) webpagetest (0) -automated message |
zeftilldeath
force-pushed
the
video-main-media-caption
branch
from
4f28c6b
to
1104f55
Compare
| @fragments.inlineSvg("information", "icon", List("rounded-icon", "centered-icon")) | ||
| @Html(caption) | ||
| </figcaption> | ||
| @if(mvt.ABNewNavVariantSeven.isParticipating) { |
There was a problem hiding this comment.
To clarify, is this solely an issue for people in this A/B test? If so would have been helpful to put this in the description.
| // These events are so that other libraries (e.g. Ophan) can hook into events without | ||
| // needing to know about videojs | ||
| function bindGlobalEvents(player) { | ||
| player.on('playing', function () { | ||
| kruxTracking(player, 'videoPlaying'); | ||
| bean.fire(document.body, 'videoPlaying'); | ||
| hideCaption(); |
There was a problem hiding this comment.
Are you doing this all the time or only when the video plays
|
It would be worth testing this same scenario with YouTube atoms, as I think they would need to be updated separately, though this can be done in a separate PR. |
|
Would be helpful for me to talk with @zeftilldeath or @NataliaLKB to provide a bit more context if possible. |
|
@gidsg Best to chat to @zeftilldeath about this! I am in NY until the 14th. But after the 14th I am free to chat 😄 |
|
Talked through IRL with @zeftilldeath looks good to me 👍 🎥 |
|
Seen on PROD (merged by @zeftilldeath 16 minutes and 44 seconds ago) Please check your changes! |
Currently, within the new-header test we're getting some horrible banding due to the placement of captions under video-main-media. If this becomes permanent we'll need to support youtube videos too.
This will not do
This will do
When a video is main media AND has a caption AND there is a feature tone, you get this horrible white banding under the image to make room for the caption. Instead with a lot of help from @NataliaLKB I have used the caption toggle just like images that are main media.