Fix immersive media atom template by using named parameter for mediaWrapper #16157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gidsg
changed the title
|
Thanks Gids! |
|
PR build results: screenshots exceptions (0) webpagetest (2) -automated message |
akash1810
approved these changes
Mar 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Previously we were passing unnamed parameters in the YouTube template. This meant the
mediaWrapperwasn't being correctly set I think because the compiler thought it to be a different parameter.What is the value of this and can you measure success?
Fixes immersive template
Does this affect other platforms - Amp, Apps, etc?
No
Screenshots
Before
After
Tested in CODE?
No
CC @duarte