explicitly set display duration to true for youtube atom embeds #16306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akash1810
approved these changes
Mar 30, 2017
| val asset: Asset = Asset( | ||
| AssetType.Image, | ||
| Some("image/jpeg"), | ||
| Some("http://static.guim.co.uk/sys-images/Guardian/Pix/pictures/2013/7/5/1373023097878/b6a5a492-cc18-4f30-9809-88467e07ebfa-460x276.jpeg"), |
There was a problem hiding this comment.
It's a test fixture 😉 I don't think it really matters in this case.
akash1810
approved these changes
Mar 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Explicitly sets display duration to true for embedded youtube atoms in articles.
This is intended to be the default but I think possibly regressed as part of the removal of named arguments in #16015.
What is the value of this and can you measure success?
Fix regression spotted by @duarte
Does this affect other platforms - Amp, Apps, etc?
No, AMP uses the standard
amp-youtubeto render these.Screenshots
Tested in CODE?
No