use 16x9 image for video page meta itemprop image #16471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TBonnin
reviewed
Apr 19, 2017
| @@ -79,7 +79,11 @@ | |||
| <meta itemprop="width" content="@mv.videos.width" /> | |||
| } | |||
| <meta itemprop="requiresSubscription" content="false" /> | |||
| <meta itemprop="image" content="@Html(video.content.signedArticleImage)" /> | |||
| @defining(video.mediaAtom.flatMap(_.posterImage) orElse video.elements.thumbnail.map(_.images)) {sixteenByNineImage => | |||
| @sixteenByNineImage.map {i => | |||
There was a problem hiding this comment.
Can we have all this logic in the content class rather than the template?
TBonnin
approved these changes
Apr 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Currently we are using a 5x3 image as the meta itemprop image on video pages. I noticed in some video container views within Google SERPs the images are being either 'black boxed' or cropped.
This PR changes video pages to use a 16x9 meta image, so they should now fit correctly into these components.
What is the value of this and can you measure success?
Experiment to see if appearance of video pages is improved in SERPs.
Does this affect other platforms - Amp, Apps, etc?
No
Screenshots
N/A
Tested in CODE?
No