Use a better solution to fix the ID test that doesnt work in local #16536
Conversation
There was a problem hiding this comment.
Something like this https://gist.github.com/TBonnin/7b11368f841796dbcb286c5fe4e12cec, in additions to your changes of IdApi and IdApiClient, would be cleaner.
Then in all the tests involving identity config you can provide your own implementation of the IdConfig trait, the same way we are providing TestWsClient for instance.
|
@TBonnin please let me know what do you think now and please let me know if you have further suggestions. |
identity/test/package.scala
Outdated
| val accountDeletionApiKey: String = ??? | ||
| val url: String = ??? | ||
| val oauthUrl: String = ??? | ||
| val domain: String = ??? |
There was a problem hiding this comment.
You are gonna need real values here
There was a problem hiding this comment.
Yeap, I'm working on a fix now.
|
PR build results: screenshots exceptions (0) webpagetest (2) -automated message |
|
Thanks for the review @TBonnin |
|
Seen on PROD (merged by @DiegoVazquezNanini 15 minutes and 5 seconds ago) Please check your changes! |
This PR fix an issue with some ID tests that fail if you run the tests locally.
@jfsoul @markjamesbutler @TBonnin