Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wide variant to .manage-account__switches #18420

Merged
merged 18 commits into from Dec 8, 2017
Merged

Conversation

walaura
Copy link

@walaura walaura commented Dec 6, 2017

What does this change?

Updates the V2 consent list in the journey page to a huge layout that has more presence in the page and lays the consents in a better better and cleaner way

What is the value of this?

The page looks more parseable at first glance

Screenshots

✨ new ✨

screen shot 2017-12-07 at 16 58 33

🕸 old 🕸

screen shot 2017-12-07 at 16 59 16

@PRBuilds
Copy link

PRBuilds commented Dec 6, 2017

PRbuilds results:

Screenshots
desktop.pngtablet.pngmobile.pngwide.png

💚 Exceptions
thrown-exceptions.js

💚 A11y validation
a11y-report.txt

Apache Benchmark Load Testing
loadtesting.txt

💚 Microdata Validation
microdata.txt

--automated message

@walaura walaura changed the title Display V2 consents in a single column Turn consent checkboxes into consent switches Dec 7, 2017
@walaura walaura changed the title Turn consent checkboxes into consent switches Update consent switch design Dec 7, 2017
@walaura walaura changed the title Update consent switch design Add long consent switch design Dec 7, 2017
@walaura walaura changed the title Add long consent switch design Add wide variant to .manage-account__switches Dec 7, 2017
@walaura walaura merged commit 349ff4e into master Dec 8, 2017
@walaura walaura deleted the v2-single-column-consents branch December 8, 2017 10:23
@prout-bot
Copy link
Collaborator

Seen on PROD (merged by @walaura 21 minutes and 32 seconds ago)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants