Clicking outside the menu, closes it #18471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PRbuilds results: Screenshots 💚 Exceptions 💚 A11y validation Apache Benchmark Load Testing 💚 Microdata Validation --automated message |
|
lovely 👍 |
|
Thank you! |
|
Seen on PROD (merged by @NataliaLKB 19 minutes and 47 seconds ago)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
When the menu is open, if you click outside of it the menu should close.
(In this gif you can't see my mouse, so I hovered of the stories. I actually only clicked on the side of the page)
What is the value of this and can you measure success?
More expected UX
Does this affect other platforms - Amp, Apps, etc?
Nope
Does this affect GLabs Paid Content Pages? Should it have support for Paid Content?
Nope
Tested in CODE?
Nope