Update consent journey footer #18472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PRbuilds results: Screenshots 💚 Exceptions 💚 A11y validation Apache Benchmark Load Testing 💚 Microdata Validation --automated message |
mariogalic
approved these changes
Dec 12, 2017
walaura
force-pushed
the
update-consent-journey-footer
branch
from
c9f4e0e
to
3a69f8b
Compare
|
Seen on PROD (merged by @walaura 24 minutes and 37 seconds ago)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Makes the footer in the consent journey page significantly smaller, also upgrades the page to the new
HtmlPageinfra making future changes trivialWhat is the value of this and can you measure success?
Oh wow scrolling down at the moment is ROUGH. Should also help retention, ideally we don't want any links to the outside on this whole flow
Can i see it?
Sure thing! But we are still on hold for the final design and this PR is more about changing the page so any hypothetical header/footer may wrap it. Seeing it now it really should be over the bar instead of doing a weird scroll thing at all really.