Account and email-prefs page update #19612
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PRbuilds results: Screenshots 💚 Exceptions 💚 A11y validation 💚 Microdata Validation Apache Benchmark Load Testing LightHouse Reporting --automated message |
added 2 commits
May 3, 2018 16:44
Calum-Campbell
changed the title
walaura
reviewed
May 4, 2018
| @@ -37,6 +37,7 @@ $checkbox-size: $gs-gutter / 1.25; | |||
| @include mq(desktop) { | |||
| grid-template-columns: repeat(2, 1fr); | |||
| grid-auto-rows: 1fr; | |||
| width: gs-span(8); | |||
There was a problem hiding this comment.
this component should not know about with at this scope (that way it can be added to any pages of any width). It will however take the full width of the page by default!
|
Closing this as it has been superseded by #19726 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
What is the value of this and can you measure success?
Does this affect other platforms - Amp, Apps, etc?
No
Does this affect GLabs Paid Content Pages? Should it have support for Paid Content?
Screenshots
Email prefs page
Account page
Tested in CODE?