WIP - Email front flagship #20465
WIP - Email front flagship #20465
Conversation
| @faciaCard(classesForCard(card, withImage = true)) { | ||
| @row(Seq("no-pad")){ | ||
| <a class="fc-link" href="@card.header.url.hrefWithRel"> | ||
| <img class="full-width" src="https://i.guim.co.uk/img/media/60478bdc559fa72fe4fe0ac09636f78df9f3cdb9/3_170_3910_2345/master/3910.jpg?width=500&quality=60&fit=max&s=a31b2353a7f08f4417006bda4a77acf5" alt="@card.header.headline"> |
There was a problem hiding this comment.
TODO - use the correct asset
| @@ -286,6 +315,7 @@ | |||
| } | |||
|
|
|||
| @layout.CollectionEmail.fromPressedPage(page).collections.zipWithIndex.map { | |||
| case (collection: EmailContentContainer, index) if collection.displayName == "Flagship" => { @renderFlagshipContainer(collection) } | |||
There was a problem hiding this comment.
TODO - correct container name
There was a problem hiding this comment.
Use the values here #20473
|
PRbuilds results: Screenshots 💚 Exceptions 💚 A11y validation 💚 Microdata Validation Apache Benchmark Load Testing LightHouse Reporting --automated message |
tomrf1
force-pushed
the
email-front-flagship
branch
from
3cccce0
to
6ad6958
Compare
|
👍 🥇 |
| FlagshipEmailContainerSwitch.isSwitchedOn && | ||
| now.isAfter(GoLiveDateTime) && | ||
| now.getDayOfWeek != SATURDAY && now.getDayOfWeek != SUNDAY && | ||
| !(now.getDayOfWeek == MONDAY && now.getHourOfDay < 4) |
There was a problem hiding this comment.
My head is spinning 🤯 is this 4am, London time? It might be worth adding a small comment to clarify these two lines.
| @@ -206,6 +207,30 @@ | |||
| } | |||
| } | |||
|
|
|||
| @renderFlagshipContainer(collection: EmailContentContainer) = { | |||
|
FYI... email newsletter send times... UK 5am local time We want to pick these up weekdays only, no container on weekends in emails newsletters |
|
Additionally.. |
tomrf1
force-pushed
the
email-front-flagship
branch
from
acf413e
to
6c1601c
Compare
tomrf1
force-pushed
the
email-front-flagship
branch
from
6c1601c
to
5ec2b8d
Compare
prout-bot
added
Pending-on-PROD
Seen-on-PROD
and removed
Do not merge ⚠️
Pending-on-PROD
labels
|
Seen on PROD (merged by @tomrf1 14 minutes and 17 seconds ago)
|
What does this change?
The new flagship podcast will have a permanent weekday spot in the email front.
The container will be backfilled from the tag series, and the container will display a single card for the latest episode.
The image is hardcoded, not taken from the content. It otherwise looks like a normal
mediumcontainer.It relies on the name of the container being constant. This is brittle, but the alternative is making this configurable in the fronts tool and reflected in the model (which is a lot of work for a single special case).
Screenshots
(with football weekly for now)
What is the value of this and can you measure success?
Checklist
Does this affect other platforms?
Does this affect GLabs Paid Content Pages? Should it have support for Paid Content?
Does this change break ad-free?
Accessibility test checklist
Tested