Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing npm-shrinkwrap #3027

Merged
merged 1 commit into from Feb 5, 2014
Merged

Removing npm-shrinkwrap #3027

merged 1 commit into from Feb 5, 2014

Conversation

ironsidevsquincy
Copy link

Good idea in theory, but trips people up when updating package.json, plus looks like macs cant create one when it has a postinstall (paulmillr/chokidar#92), and doesn't seem to have solved our team city build problems (http://teamcity.gudev.gnl:8111/viewLog.html?buildId=174571&buildTypeId=bt1216&tab=buildLog)

Any objections?

@jamesgorrie
Copy link
Contributor

👍
Problem is the problem still exists. Will have a think.

@ironsidevsquincy
Copy link
Author

Seems the only solution is to have our own copy of the npm repo, locally

ironsidevsquincy pushed a commit that referenced this pull request Feb 5, 2014
@ironsidevsquincy ironsidevsquincy merged commit 0160fd6 into master Feb 5, 2014
@ironsidevsquincy ironsidevsquincy deleted the remove-shrinkwrap branch February 5, 2014 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants