New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linked data for tag/section pages #9249
Conversation
val data: JsValue = Json.parse(script.first().html()) | ||
val organisation = data.asInstanceOf[JsArray](0) | ||
val appIndexer = data.asInstanceOf[JsArray](1) | ||
val organisation: JsValue = Json.parse(script.first().html()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.first()
sounds a bit flaky. Script order might change and the test will break.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it specifically looks for the Organization section, if we have more than one organisation then it's a bug, so the assertion on line 18 will fail
Sorry couldn't find anything describing why this could be useful. Do you have any documentation available? I think that a simple list of links is redundant, as that's the only information that tag/section pages carry. |
Looks fine, the only concern is page size. Is there a limit on the number of articles? Would be nice to have one 👍 |
would shortened URLs defeat the purpose? |
@paperboyo Not sure I understand 100%. If it helps, the purpose here is to link together the world's graph of data, so they have to be the canonical url of whatever it is so google etc can understand it's the same as all the other links to the same content. We wouldn't officially be able to get away with a redirect although who's to say google don't have something to deal with that. |
@johnduffell yes. thx! |
I have added linked data to non curated tag and section pages. Basically shows the urls of all of the articles in that page. This will help google to know what that page offers of importance.
The pages themselves still need marking up to describe the content itself, also curated fronts need marking up similarly.